Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom underlying services #16

Closed
wants to merge 3 commits into from
Closed

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented May 2, 2023

Signed-off-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
@eguzki eguzki requested a review from a team May 2, 2023 13:48
@eguzki
Copy link
Contributor Author

eguzki commented May 2, 2023

There are still some TODOs and empty sections. Looking for some first comments, though.

# Drawbacks
[drawbacks]: #drawbacks

TODO
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One potential drawback is that we do not want users to change some settings. From the top of my head, I can think of Authorino spec.clusterWide and authConfigLabelSelectors, which could mean that the user could easily end up with AuthPolicy that will be reconciled by Kuadrant but won't be picked up in Authorino.

Copy link
Contributor Author

@eguzki eguzki May 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kuadrant should reconcile those changes from the external services, right? More specifically, when the Authorino CR is (externally) updated and the label selectors are updated, the AuthConfig CR's managed by kuadrant should reconcile to match.

name: <kuadrant-name>
namespace: <kuadrant-namespace>
spec:
authorinoTargetRef:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
authorinoTargetRef:
authorinoRef:

authorinoTargetRef:
name: <authorino-name>
namespace: <authorino-namespace>
limitadorTargetRef:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
limitadorTargetRef:
limitadorRef:

@eguzki
Copy link
Contributor Author

eguzki commented Jul 24, 2023

Updating with my latest changes and handing over to anyone from the team

@eguzki
Copy link
Contributor Author

eguzki commented Sep 12, 2023

Superseded by #25

@eguzki eguzki closed this Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants