From 87f24e12281c71d5d515e6a03de3220b9980b4e8 Mon Sep 17 00:00:00 2001 From: Arik Fraimovich Date: Tue, 14 Jun 2016 10:41:01 +0300 Subject: [PATCH] Return meaningful error when there is no cached result. Previously it was crashing as it was trying to access an unreferenced variables (query_result). --- handlers/query_results.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/handlers/query_results.py b/handlers/query_results.py index dc44f6eeb8..033b79132f 100644 --- a/handlers/query_results.py +++ b/handlers/query_results.py @@ -115,6 +115,8 @@ def get(self, query_id=None, query_result_id=None, filetype='json'): if query_result_id: query_result = get_object_or_404(models.QueryResult.get_by_id_and_org, query_result_id, self.current_org) + else: + query_result = None if query_result: require_access(query_result.data_source.groups, self.current_user, view_only) @@ -156,7 +158,7 @@ def get(self, query_id=None, query_result_id=None, filetype='json'): return response else: - abort(404) + abort(404, message='No cached result found for this query.') def make_json_response(self, query_result): data = json.dumps({'query_result': query_result.to_dict()}, cls=utils.JSONEncoder)