From 6f79b71a6979de016c8db3f76fbd6d5cbba39cdc Mon Sep 17 00:00:00 2001 From: mjptree Date: Sun, 3 Nov 2019 16:16:14 +0000 Subject: [PATCH 1/2] Correct deprecated `is_global` IPv6 documentation This method does currently not return false for the `site_local` unicast address space. The documentation of the `is_unicast_global` method on lines 1352 - 1382 suggests that this is intentional as the site-local prefix must no longer be supported in new implementations, thus the documentation can safely be updated to reflect that information. If not so, either the `is_unicast_global` method should be updated to exclude the unicast site-local address space, or the `is_global` method itself. --- src/libstd/net/ip.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libstd/net/ip.rs b/src/libstd/net/ip.rs index 70b68d1348550..719df4449a444 100644 --- a/src/libstd/net/ip.rs +++ b/src/libstd/net/ip.rs @@ -1130,7 +1130,7 @@ impl Ipv6Addr { /// The following return [`false`]: /// /// - the loopback address - /// - link-local, site-local, and unique local unicast addresses + /// - link-local, and unique local unicast addresses /// - interface-, link-, realm-, admin- and site-local multicast addresses /// /// [`true`]: ../../std/primitive.bool.html From 15863a60e6426fdf282d47258b582be0cf7e0d1a Mon Sep 17 00:00:00 2001 From: mjptree Date: Sat, 9 Nov 2019 12:27:09 +0000 Subject: [PATCH 2/2] Update src/libstd/net/ip.rs I assumed some sort of Oxford-comma case here, bit have to admit English is not my first language. Co-Authored-By: kennytm --- src/libstd/net/ip.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libstd/net/ip.rs b/src/libstd/net/ip.rs index 719df4449a444..5a3add3678e43 100644 --- a/src/libstd/net/ip.rs +++ b/src/libstd/net/ip.rs @@ -1130,7 +1130,7 @@ impl Ipv6Addr { /// The following return [`false`]: /// /// - the loopback address - /// - link-local, and unique local unicast addresses + /// - link-local and unique local unicast addresses /// - interface-, link-, realm-, admin- and site-local multicast addresses /// /// [`true`]: ../../std/primitive.bool.html