Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Public initialise params method #172

Closed
daniel-dodd opened this issue Jan 4, 2023 · 1 comment
Closed

dev: Public initialise params method #172

daniel-dodd opened this issue Jan 4, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@daniel-dodd
Copy link
Member

Public method for parameter initialisation on all objects.

Example

Current

import jaxkern as jk
import gpjax as gpx
import jax.random as jr
prior = gpx.Prior(kernel = jk.RBF())

# Current initialisation method:
key = jr.PRNGKey(123)
params = prior._initialise_params(key)

Proposed

# Preferred:
params = prior.init_params(key)

# Alternative:
params = prior.initialise_params(key)

Thoughts @thomaspinder?

@daniel-dodd daniel-dodd added enhancement New feature or request good first issue Good for newcomers labels Jan 4, 2023
@thomaspinder
Copy link
Collaborator

.init_params(key) looks good to me. We need to make sure we add a deprecation flag to ._initialise_params(key) and don't just drop it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants