From f4e2569d716d0919f8e0cf5d447300ad02de7017 Mon Sep 17 00:00:00 2001
From: Jack Works <jackworks@protonmail.com>
Date: Wed, 31 Aug 2022 11:38:29 +0800
Subject: [PATCH] fix: [[GetOwnPropertyDescriptor]] returns undefined

compatibility with near-membrane
---
 .changeset/honest-students-play.md |  5 +++++
 __tests__/brand.ts                 | 16 ++++++++++++++++
 src/Async-Call-Generator.ts        |  5 +++++
 src/Async-Call.ts                  |  5 +++++
 4 files changed, 31 insertions(+)
 create mode 100644 .changeset/honest-students-play.md

diff --git a/.changeset/honest-students-play.md b/.changeset/honest-students-play.md
new file mode 100644
index 0000000..57cd0b8
--- /dev/null
+++ b/.changeset/honest-students-play.md
@@ -0,0 +1,5 @@
+---
+'async-call-rpc': patch
+---
+
+fix [[GetOwnPropertyDescriptor]] returns undefined
diff --git a/__tests__/brand.ts b/__tests__/brand.ts
index ab6311e..6af8e4f 100644
--- a/__tests__/brand.ts
+++ b/__tests__/brand.ts
@@ -17,6 +17,14 @@ it(
         // Method name check
         expect(server.add.name).toBe('add')
 
+        // [[GetOwnPropertyDescriptor]] check
+        {
+            const method = Object.getOwnPropertyDescriptor(server, 'missing-method')
+            expect(method).toBeTypeOf('object')
+            expect(Reflect.has(server, 'missing-method')).toBeTruthy()
+            expect((server as any)['missing-method']).toBe(method!.value!)
+        }
+
         // Result check
         const q = server.add(0, 1)
         expect(q).toBeInstanceOf(Promise)
@@ -40,6 +48,14 @@ it(
         // Method name check
         expect(server.echo.name).toBe('echo')
 
+        // [[GetOwnPropertyDescriptor]] check
+        {
+            const method = Object.getOwnPropertyDescriptor(server, 'missing-method')
+            expect(method).toBeTypeOf('object')
+            expect(Reflect.has(server, 'missing-method')).toBeTruthy()
+            expect((server as any)['missing-method']).toBe(method!.value!)
+        }
+
         // Result check
         const iter = server.echo([])
         async function* __() {}
diff --git a/src/Async-Call-Generator.ts b/src/Async-Call-Generator.ts
index 4d44052..45db345 100644
--- a/src/Async-Call-Generator.ts
+++ b/src/Async-Call-Generator.ts
@@ -176,6 +176,11 @@ export function AsyncGeneratorCall<OtherSideImplementedFunctions = {}>(
     return new Proxy(methodContainer, {
         getPrototypeOf: () => null,
         setPrototypeOf: (_, val) => val === null,
+        // some library will treat this object as a normal object and run algorithm steps in https://tc39.es/ecma262/#sec-ordinaryget
+        getOwnPropertyDescriptor(_, method) {
+            if (!(method in methodContainer)) (getTrap as any)[method] // trigger [[Get]]
+            return Object.getOwnPropertyDescriptor(methodContainer, method)
+        },
     }) as AsyncGeneratorVersionOf<OtherSideImplementedFunctions>
 }
 class _AsyncGenerator implements AsyncIterableIterator<unknown>, AsyncIterator<unknown, unknown, unknown> {
diff --git a/src/Async-Call.ts b/src/Async-Call.ts
index 09c0761..282d22e 100644
--- a/src/Async-Call.ts
+++ b/src/Async-Call.ts
@@ -381,6 +381,11 @@ export function AsyncCall<OtherSideImplementedFunctions = {}>(
     return new Proxy(methodContainer, {
         getPrototypeOf: () => null,
         setPrototypeOf: (_, value) => value === null,
+        // some library will treat this object as a normal object and run algorithm steps in https://tc39.es/ecma262/#sec-ordinaryget
+        getOwnPropertyDescriptor(_, method) {
+            if (!(method in methodContainer)) (getTrap as any)[method] // trigger [[Get]]
+            return Object.getOwnPropertyDescriptor(methodContainer, method)
+        },
     }) as AsyncVersionOf<OtherSideImplementedFunctions>
 }
 // Assume a console object in global if there is no custom logger provided