From 4a69fad3853f08ef6cc07e7f343dad7032223359 Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Thu, 9 Jul 2020 06:32:27 +0200 Subject: [PATCH 1/3] Add JavaFX installation notes --- .../guidelines-for-setting-up-a-local-workspace.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/docs/getting-into-the-code/guidelines-for-setting-up-a-local-workspace.md b/docs/getting-into-the-code/guidelines-for-setting-up-a-local-workspace.md index 95b55e28b9c..b01c992eb38 100644 --- a/docs/getting-into-the-code/guidelines-for-setting-up-a-local-workspace.md +++ b/docs/getting-into-the-code/guidelines-for-setting-up-a-local-workspace.md @@ -4,7 +4,7 @@ This guide explains how to set up your environment for development of JabRef. It ```text The most important step is to configure your IDE. -In case you know how to install JDK14 and to fork JabRef's code, +In case you know how to install JDK14 with JavaFX support and to fork JabRef's code, please scroll down to the IDE setup. ``` @@ -18,9 +18,11 @@ This section list the prerequisites you need to get started to develop JabRef. A ### Java Development Kit 14 -A working Java 14 installation is required. In the command line \(terminal in Linux, cmd in Windows\) run `javac -version` and make sure that the reported version is Java 14 \(e.g `javac 14`\). If `javac` is not found or a wrong version is reported, check your PATH environment variable, your `JAVA_HOME` environment variable or install the most recent JDK. +A working Java (Develoment Kit) 14 installation is required. In the command line \(terminal in Linux, cmd in Windows\) run `javac -version` and make sure that the reported version is Java 14 \(e.g `javac 14`\). If `javac` is not found or a wrong version is reported, check your PATH environment variable, your `JAVA_HOME` environment variable or install the most recent JDK. -Download the JDK from [https://jdk.java.net/](https://jdk.java.net/). On Windows, you can execute `choco install openjdk` \(requires [installation of chocolatey - a package manager for Windows](https://chocolatey.org/install)\). +[JavaFX is not part of the default JDK any more](https://www.reddit.com/r/java/comments/82qm9x/javafx_will_be_removed_from_the_java_jdk_in_jdk_11/), it needs to be installed separately if not using a special JDK. We recommend to setup the full Liberica JDK including JavaFX. You can get it from . On Windows, you can execute `choco install libericajdkfull` \(requires [installation of chocolatey - a package manager for Windows](https://chocolatey.org/install)\). + +Alterantively, you can download and install the JDK from [https://jdk.java.net/](https://jdk.java.net/). Afterwords, download download the "jmods" JavaFX 14 zip archive from and put the `.jmod` files into `C:\Program Files\OpenJDK\jdk-14.0.1\jmods`. ### GitHub Account From 639fed1732959cbe19bb4aa1d50c43edb3c8e3b8 Mon Sep 17 00:00:00 2001 From: Christoph Date: Thu, 9 Jul 2020 07:57:41 +0200 Subject: [PATCH 2/3] Update guidelines-for-setting-up-a-local-workspace.md Fix typo and also add javafx to jdk14 --- .../guidelines-for-setting-up-a-local-workspace.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/getting-into-the-code/guidelines-for-setting-up-a-local-workspace.md b/docs/getting-into-the-code/guidelines-for-setting-up-a-local-workspace.md index b01c992eb38..e4cc9dc77ae 100644 --- a/docs/getting-into-the-code/guidelines-for-setting-up-a-local-workspace.md +++ b/docs/getting-into-the-code/guidelines-for-setting-up-a-local-workspace.md @@ -18,11 +18,11 @@ This section list the prerequisites you need to get started to develop JabRef. A ### Java Development Kit 14 -A working Java (Develoment Kit) 14 installation is required. In the command line \(terminal in Linux, cmd in Windows\) run `javac -version` and make sure that the reported version is Java 14 \(e.g `javac 14`\). If `javac` is not found or a wrong version is reported, check your PATH environment variable, your `JAVA_HOME` environment variable or install the most recent JDK. +A working Java (Develoment Kit) 14 installation with Java FX support is required. In the command line \(terminal in Linux, cmd in Windows\) run `javac -version` and make sure that the reported version is Java 14 \(e.g `javac 14`\). If `javac` is not found or a wrong version is reported, check your PATH environment variable, your `JAVA_HOME` environment variable or install the most recent JDK. [JavaFX is not part of the default JDK any more](https://www.reddit.com/r/java/comments/82qm9x/javafx_will_be_removed_from_the_java_jdk_in_jdk_11/), it needs to be installed separately if not using a special JDK. We recommend to setup the full Liberica JDK including JavaFX. You can get it from . On Windows, you can execute `choco install libericajdkfull` \(requires [installation of chocolatey - a package manager for Windows](https://chocolatey.org/install)\). -Alterantively, you can download and install the JDK from [https://jdk.java.net/](https://jdk.java.net/). Afterwords, download download the "jmods" JavaFX 14 zip archive from and put the `.jmod` files into `C:\Program Files\OpenJDK\jdk-14.0.1\jmods`. +Alternatively, you can download and install the JDK from [https://jdk.java.net/](https://jdk.java.net/). Afterwords, download download the "jmods" JavaFX 14 zip archive from and put the `.jmod` files into `C:\Program Files\OpenJDK\jdk-14.0.1\jmods`. ### GitHub Account From c1b0aa3023a5dc2f3aea595c26887358a88a346c Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Thu, 9 Jul 2020 21:01:08 +0200 Subject: [PATCH 3/3] Fix typo --- .../guidelines-for-setting-up-a-local-workspace.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/getting-into-the-code/guidelines-for-setting-up-a-local-workspace.md b/docs/getting-into-the-code/guidelines-for-setting-up-a-local-workspace.md index e4cc9dc77ae..37c5c2da7eb 100644 --- a/docs/getting-into-the-code/guidelines-for-setting-up-a-local-workspace.md +++ b/docs/getting-into-the-code/guidelines-for-setting-up-a-local-workspace.md @@ -22,7 +22,7 @@ A working Java (Develoment Kit) 14 installation with Java FX support is required [JavaFX is not part of the default JDK any more](https://www.reddit.com/r/java/comments/82qm9x/javafx_will_be_removed_from_the_java_jdk_in_jdk_11/), it needs to be installed separately if not using a special JDK. We recommend to setup the full Liberica JDK including JavaFX. You can get it from . On Windows, you can execute `choco install libericajdkfull` \(requires [installation of chocolatey - a package manager for Windows](https://chocolatey.org/install)\). -Alternatively, you can download and install the JDK from [https://jdk.java.net/](https://jdk.java.net/). Afterwords, download download the "jmods" JavaFX 14 zip archive from and put the `.jmod` files into `C:\Program Files\OpenJDK\jdk-14.0.1\jmods`. +Alternatively, you can download and install the JDK from [https://jdk.java.net/](https://jdk.java.net/). Afterwards, download download the "jmods" JavaFX 14 zip archive from and put the `.jmod` files into `C:\Program Files\OpenJDK\jdk-14.0.1\jmods`. ### GitHub Account