From 73a9ca1298a3e47ef8d06e51d34083f6dcf09fcd Mon Sep 17 00:00:00 2001
From: Simon Harrer <simon.harrer@gmail.com>
Date: Fri, 9 Oct 2015 23:03:55 +0200
Subject: [PATCH] Inline getCouldNot* methods for less methods to override and
 lesser code complexity.

---
 .../push/AbstractPushToApplication.java       | 30 +++++--------------
 .../sf/jabref/external/push/PushToEmacs.java  |  3 +-
 .../sf/jabref/external/push/PushToLyx.java    | 29 ++++++++----------
 .../sf/jabref/external/push/PushToVim.java    |  3 +-
 4 files changed, 24 insertions(+), 41 deletions(-)

diff --git a/src/main/java/net/sf/jabref/external/push/AbstractPushToApplication.java b/src/main/java/net/sf/jabref/external/push/AbstractPushToApplication.java
index 8d269d85c3c..66b5f76584e 100644
--- a/src/main/java/net/sf/jabref/external/push/AbstractPushToApplication.java
+++ b/src/main/java/net/sf/jabref/external/push/AbstractPushToApplication.java
@@ -90,7 +90,9 @@ public void pushEntries(BibtexDatabase database, BibtexEntry[] entries, String k
         // In case it didn't work
         catch (IOException excep) {
             couldNotCall = true;
-            LOGGER.warn(getCouldNotCall());
+
+            LOGGER.warn(Localization.lang("Error") + ": "
+                    + Localization.lang("Could not call executable") + " '" + commandPath + "'.");
         }
     }
 
@@ -102,9 +104,11 @@ public void operationCompleted(BasePanel panel) {
                     + Localization.lang("Path to %0 not defined", getApplicationName()) + ".");
             // @formatter:on
         } else if (couldNotCall) {
-            panel.output(getCouldNotCall());
+            panel.output(Localization.lang("Error") + ": "
+                    + Localization.lang("Could not call executable") + " '" + commandPath + "'.");
         } else if (couldNotConnect) {
-            panel.output(getCouldNotConnect());
+            panel.output(Localization.lang("Error") + ": "
+                    + Localization.lang("Could not connect to ") + getApplicationName() + ".");
         } else {
             panel.output(Localization.lang("Pushed citations to %0", getApplicationName()) + ".");
         }
@@ -178,24 +182,4 @@ public void storeSettings() {
         Globals.prefs.put(commandPathPreferenceKey, Path.getText());
     }
 
-    /**
-     * @return Error message in case couldNotCall is set
-     */
-    protected String getCouldNotCall() {
-        // @formatter:off
-        return Localization.lang("Error") + ": "
-                + Localization.lang("Could not call executable") + " '" + commandPath + "'.";
-        // @formatter:on
-    }
-
-    /**
-     * @return Error message in case couldNotConnect is set
-     */
-    protected String getCouldNotConnect() {
-        // @formatter:off
-        return Localization.lang("Error") + ": "
-                + Localization.lang("Could not connect to ") + getApplicationName() + ".";
-        // @formatter:on
-    }
-
 }
diff --git a/src/main/java/net/sf/jabref/external/push/PushToEmacs.java b/src/main/java/net/sf/jabref/external/push/PushToEmacs.java
index 4dd79d01bd6..f058a94823d 100644
--- a/src/main/java/net/sf/jabref/external/push/PushToEmacs.java
+++ b/src/main/java/net/sf/jabref/external/push/PushToEmacs.java
@@ -171,8 +171,9 @@ public void operationCompleted(BasePanel panel) {
                     + "the emacsclient/gnuclient program installed and available in the PATH."),
                     Localization.lang("Error"), JOptionPane.ERROR_MESSAGE);
             // @formatter:on
+        } else {
+            super.operationCompleted(panel);
         }
-        super.operationCompleted(panel);
     }
 
     @Override
diff --git a/src/main/java/net/sf/jabref/external/push/PushToLyx.java b/src/main/java/net/sf/jabref/external/push/PushToLyx.java
index 5db82726957..8efc1003fb0 100644
--- a/src/main/java/net/sf/jabref/external/push/PushToLyx.java
+++ b/src/main/java/net/sf/jabref/external/push/PushToLyx.java
@@ -23,6 +23,7 @@
 import javax.swing.*;
 
 import net.sf.jabref.*;
+import net.sf.jabref.gui.BasePanel;
 import net.sf.jabref.gui.IconTheme;
 import net.sf.jabref.logic.l10n.Localization;
 import net.sf.jabref.model.database.BibtexDatabase;
@@ -46,22 +47,18 @@ protected void initParameters() {
     }
 
     @Override
-    protected String getCouldNotCall() {
-        // @formatter:off
-        return Localization.lang("Error") + ": " +
-                Localization.lang("unable to write to") + " " + commandPath +
-                ".in";
-        // @formatter:on
-    }
-
-    @Override
-    protected String getCouldNotConnect() {
-        // @formatter:off
-        return Localization.lang("Error") + ": " +
-                Localization.lang("verify that LyX is running and that the lyxpipe is valid")
-                + ". [" + commandPath + "]";
-        // @formatter:on
-
+    public void operationCompleted(BasePanel panel) {
+        if(couldNotConnect) {
+            panel.output(Localization.lang("Error") + ": " +
+                    Localization.lang("verify that LyX is running and that the lyxpipe is valid")
+                    + ". [" + commandPath + "]");
+        } else if(couldNotCall) {
+            panel.output(Localization.lang("Error") + ": " +
+                    Localization.lang("unable to write to") + " " + commandPath +
+                    ".in");
+        } else {
+            super.operationCompleted(panel);
+        }
     }
 
     @Override
diff --git a/src/main/java/net/sf/jabref/external/push/PushToVim.java b/src/main/java/net/sf/jabref/external/push/PushToVim.java
index 9411f8482bb..1514d065c75 100644
--- a/src/main/java/net/sf/jabref/external/push/PushToVim.java
+++ b/src/main/java/net/sf/jabref/external/push/PushToVim.java
@@ -142,8 +142,9 @@ public void operationCompleted(BasePanel panel) {
                     Localization.lang("Could not run the 'vim' program."),
                     Localization.lang("Error"), JOptionPane.ERROR_MESSAGE);
             // formatter:on
+        } else {
+            super.operationCompleted(panel);
         }
-        super.operationCompleted(panel);
     }
     
     @Override