-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added setup for production observability (metrics via OTEL) #1924
base: main
Are you sure you want to change the base?
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
9387833 | Triggered | Generic Password | 33b49f4 | docker-compose.dev.observable.yml | View secret |
9387833 | Triggered | Generic Password | 33b49f4 | docker-compose.dev.observable.yml | View secret |
9387833 | Triggered | Generic Password | fc3a409 | prometheus.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
||
export const apiMetrics = fp(async (fastify) => { | ||
const apiMeter = opentelemetry.metrics.getMeter("API"); | ||
const latencyHistogram = apiMeter.createHistogram("API latency", { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious: what is the impact of such metric collection on the API? Does it increase our API response times much?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good setup, left some questions and comments
Description 📣
This PR adds setup for prod observability with the following components:
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets