Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for user to change to dark mode layout #3159

Closed
2 tasks done
Sebastiaan127001 opened this issue Jan 3, 2022 · 6 comments · Fixed by #3467
Closed
2 tasks done

Allow for user to change to dark mode layout #3159

Sebastiaan127001 opened this issue Jan 3, 2022 · 6 comments · Fixed by #3467
Assignees

Comments

@Sebastiaan127001
Copy link
Contributor

Sebastiaan127001 commented Jan 3, 2022

Open issues:

@Sebastiaan127001
Copy link
Contributor Author

This is more convenient for the eyes and could save energy on some displays :)

@Sebastiaan127001
Copy link
Contributor Author

maybe a toggle like this in the top right of the black header bar
https://dev.to/joyshaheb/light-dark-mode-toggle-button-using-1-variable-2021-css-js-13l

@Sebastiaan127001
Copy link
Contributor Author

see also this link for more info https://ryanfeigenbaum.com/dark-mode/

@fniessink
Copy link
Member

fniessink commented Jan 3, 2022

I have looked into this a bit, but unfortunately Semantic UI React doesn't support this out of the box so it's not trivial to implement.

Most if not all Semantic UI React components have aninverted property that we can use. Dark/light mode can be a React context. We should look at the user preference specified in the OS settings if no dark or light mode is explicitly selected.

@fniessink fniessink self-assigned this Feb 21, 2022
@fniessink fniessink mentioned this issue Feb 22, 2022
@Sebastiaan127001
Copy link
Contributor Author

Sebastiaan127001 commented Mar 8, 2022

I have reviewed v3.34.0-rc.2.
This is already a very complete layout. Maybe some minor enhancement suggestions.
If I read through this page as a guideline and walk through each advice, I see the following.

  • The white parts are too white to my opinion. According to the above article these should be off-white, like #121212 .

  • The text in the middle of the pie charts at the top are not so readable.
    image

  • Furthermore, the red alerts when a source is not working could be more readable.
    image

  • Did it pass the AXE core contrast ratio test?

@fniessink fniessink reopened this Mar 15, 2022
@fniessink
Copy link
Member

The white parts are too white to my opinion.

Do you mean the white parts of the donut charts or the white texts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants