Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.10.3 #993

Closed
wants to merge 2 commits into from
Closed

1.10.3 #993

wants to merge 2 commits into from

Conversation

eladven
Copy link
Member

@eladven eladven commented Jul 4, 2024

No description provided.

@eladven
Revert "Implelment safety and regard metrics in pure unitxt (#983)"
7013653 
This reverts commit 0a94488.
Reason for the revert: This commmit added the class Safety. Same class is already implemented in fm-eval. Since this class is registered, we can havetwo classes with the same name. We should move the implementation for fm-eval to unitxt.
@eladven
Update version to 1.10.3
45f622e
elronbandel
elronbandel requested changes Jul 7, 2024
View reviewed changes
Copy link
Member

@elronbandel elronbandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the name of the python classes of those metrics rather then reverting this change?
Safety -> SafetyMetric
Regard -> RegardMetric

@elronbandel elronbandel closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elronbandel elronbandel elronbandel requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eladven @elronbandel