-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a format based on Huggingface format #988
Added a format based on Huggingface format #988
Conversation
Signed-off-by: Yoav Katz <katz@il.ibm.com>
Signed-off-by: Yoav Katz <katz@il.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR achieve its goal.
For future we should consider:
(1) Seperate the structured representation and make it available at a dedicated field for people want to use it externally (e.g for using open ai api)
(2) change existing formats to use this mechanism
There are downsides for it - it requires access to the HF model page (e.g. sometime requires huggingface token login ). |
* Added a format based on Huggingface format Signed-off-by: Yoav Katz <katz@il.ibm.com> * Simplified format generation (no need to tokenize) Signed-off-by: Yoav Katz <katz@il.ibm.com> --------- Signed-off-by: Yoav Katz <katz@il.ibm.com>
* Added a format based on Huggingface format Signed-off-by: Yoav Katz <katz@il.ibm.com> * Simplified format generation (no need to tokenize) Signed-off-by: Yoav Katz <katz@il.ibm.com> --------- Signed-off-by: Yoav Katz <katz@il.ibm.com>
Formats the complete input for the model using the Hugginface chat template of a given model.