Added defaults to tasks #921
Conversation
Signed-off-by: Paweł Knes <pawel.knes@ibm.com>
There was a problem hiding this comment.
@pawelknes - can you also make some changes to actual tasks so they work with only needed data (such as "text_type" should default to "text", "text_a_type" should default to "first text" , "text_a_type" should default to "second text")
Then you can also remove the default from the actual cards.
unitxt/prepare/tasks/classification.py
unitxt/prepare/tasks/generation.py
unitxt/prepare/tasks/rewriting.py
Signed-off-by: Paweł Knes <pawel.knes@ibm.com>
I've added default values you mentioned as well as some others which I found quite common across different cards |
There was a problem hiding this comment.
Hi @pawelknes - I think in some cases , we can not add defaults although they are the common values (defaults, should make sense in all cases). See details in the comments below.
Signed-off-by: Paweł Knes <pawel.knes@ibm.com>
Signed-off-by: Paweł Knes <pawel.knes@ibm.com>
Removed default topic as "type_of_class"
Signed-off-by: Paweł Knes <pawel.knes@ibm.com>
* Added defaults to tasks Signed-off-by: Paweł Knes <pawel.knes@ibm.com> * added common defaults to card definitions Signed-off-by: Paweł Knes <pawel.knes@ibm.com> * Added missing json files Signed-off-by: Paweł Knes <pawel.knes@ibm.com> * Update prepare/tasks/classification.py Removed default topic as "type_of_class" * updated json file Signed-off-by: Paweł Knes <pawel.knes@ibm.com> --------- Signed-off-by: Paweł Knes <pawel.knes@ibm.com> Co-authored-by: Yoav Katz <68273864+yoavkatz@users.noreply.github.com>
Added a new field to the
Taskclass nameddefaultswhich sets default values of an instance for chosen fields in bothinputsandoutputs.For #893 issue and discussions in #908