Handle empty text in Literal Eval #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: antonp@il.ibm.com <antonp@il.ibm.com>
elronbandel
requested changes
May 13, 2024
src/unitxt/processors.py
Outdated
| @@ -237,4 +237,6 @@ def process_value(self, text: Any) -> Any: | |||
|
|
|||
| class LiteralEval(FieldOperator): | |||
| def process_value(self, text: Any) -> Any: | |||
| if not text: | |||
There was a problem hiding this comment.
Can you make this more explicit? (if text is None or text == "":) Maybe it should raise error in that case?
Also any chance you can raise ValueError with detailed message in case that not isinstance(text, str)
And thanks againg for the contributions @antonpibm !
Signed-off-by: antonp@il.ibm.com <antonp@il.ibm.com>
elronbandel
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.