Add HELM Integration: Guide, Examples and Tests #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #743 +/- ##
==========================================
- Coverage 91.42% 91.18% -0.25%
==========================================
Files 100 98 -2
Lines 10061 10002 -59
==========================================
- Hits 9198 9120 -78
- Misses 863 882 +19 ☔ View full report in Codecov by Sentry. |
dafnapension
force-pushed
the
add-helm-support
branch
from
1983ec1
to
d1972bd
Compare
Signed-off-by: Elron Bandel <elron.bandel@ibm.com>
Signed-off-by: Elron Bandel <elron.bandel@ibm.com>
elronbandel
force-pushed
the
add-helm-support
branch
from
d1972bd
to
8a9bea9
Compare
yoavkatz
reviewed
Apr 9, 2024
utils/run_helm.sh
Outdated
| --max-eval-instances 10 --suite v1 | ||
|
|
||
| if [ ! -f "benchmark_output/runs/v1/unitxt:card=cards.wnli,template=templates.classification.multi_class.relation.default,model=microsoft_phi-1_5/scenario_state.json" ]; then | ||
| echo "Error: File does not exist." >&2 |
There was a problem hiding this comment.
Maybe compare output, beyond existence of file?
yoavkatz
approved these changes
Apr 9, 2024
Signed-off-by: Elron Bandel <elron.bandel@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.