Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pandas_load_args for LoadCSV #696

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

elronbandel
Copy link
Member

Closes: #695

Signed-off-by: Elron Bandel <elron.bandel@ibm.com>
Copy link
Collaborator

@benjaminsznajder benjaminsznajder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works. But I have a general comment.

The API by requesting optional pandas_load_args argument makes the assumption that the implementation is by pd.read_csv()
The user can not make this assumption... shouldn't we just give the 'sep' argument?

tests/library/test_loaders.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.65%. Comparing base (841cb58) to head (29f4a7e).

Files Patch % Lines
src/unitxt/loaders.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
+ Coverage   89.63%   89.65%   +0.01%     
==========================================
  Files          92       92              
  Lines        8928     8944      +16     
==========================================
+ Hits         8003     8019      +16     
  Misses        925      925              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Elron Bandel <elron.bandel@ibm.com>
@elronbandel
Copy link
Member Author

Done.

@elronbandel elronbandel merged commit e5c2b8b into main Mar 20, 2024
8 checks passed
@elronbandel elronbandel deleted the add-pandas-load-args-for-csv-loader branch April 8, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support loadTSV
2 participants