Add safe and complete type parsing function to type_utils, for allowing better type checking. #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elronbandel
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #688 +/- ##
==========================================
+ Coverage 89.59% 89.63% +0.04%
==========================================
Files 92 92
Lines 8887 8928 +41
==========================================
+ Hits 7962 8003 +41
Misses 925 925 ☔ View full report in Codecov by Sentry. |
yoavkatz
reviewed
Mar 20, 2024
src/unitxt/utils.py
Outdated
| allowd_sub_strings = list(context.keys()) + allowed_tokens | ||
| if is_made_of_sub_strings(expression, allowd_sub_strings): | ||
| return eval(expression, {"__builtins__": {}}, context) | ||
| raise ValueError(f"Unreocgnized Expression: {expression}") |
There was a problem hiding this comment.
Please add a more informative message.
The expression '{expression} can not be evaluated because it contains tokens outside the allowed list of ...."
Signed-off-by: Elron Bandel <elron.bandel@ibm.com>
Signed-off-by: Elron Bandel <elron.bandel@ibm.com>
elronbandel
force-pushed
the
add-type-parsing
branch
from
d8ee3e3
to
64e37f0
Compare
yoavkatz
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.