Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics for binary tasks with float predictions #654

Merged
merged 9 commits into from
Mar 13, 2024
Merged

Conversation

lilacheden
Copy link
Member

  1. Calculate accuracy, f1, precision and recall using a threshold
  2. Calculate max F1 and max accuracy

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.55%. Comparing base (84c14be) to head (3a9d93b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
+ Coverage   89.50%   89.55%   +0.05%     
==========================================
  Files          90       90              
  Lines        8566     8590      +24     
==========================================
+ Hits         7667     7693      +26     
+ Misses        899      897       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lilacheden and others added 8 commits March 13, 2024 11:52
Signed-off-by: lilacheden <lilach.edel@gmail.com>
Signed-off-by: lilacheden <lilach.edel@gmail.com>
Signed-off-by: lilacheden <lilach.edel@gmail.com>
Signed-off-by: lilacheden <lilach.edel@gmail.com>
Signed-off-by: Ariel Gera <ariel.gera1@ibm.com>
Signed-off-by: Ariel Gera <ariel.gera1@ibm.com>
Signed-off-by: lilacheden <lilach.edel@gmail.com>
Signed-off-by: lilacheden <lilach.edel@gmail.com>
Copy link
Member

@elronbandel elronbandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add one sentence docstring about the BinaryMax metric

Signed-off-by: lilacheden <lilach.edel@gmail.com>
@lilacheden lilacheden merged commit a5b1dd5 into main Mar 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants