-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow dicts in overwrite args of fetched artifact #598
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #598 +/- ##
==========================================
+ Coverage 88.46% 88.55% +0.09%
==========================================
Files 87 87
Lines 7779 7858 +79
==========================================
+ Hits 6882 6959 +77
- Misses 897 899 +2 ☔ View full report in Codecov by Sentry. |
de6aa4e
to
c06213b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep in mind hugginface forbid the use of this character in datasets query strings:
<>:/\|?*
Meaning you can not use the new syntax with :
so if you can come up with syntax that can leave under this restriction it will be good. Also maybe we should add internally an assertion that forbid this characters in names and strings with a proper message that huggingface wont support it.
This is the hugginface error for reference:
datasets.builder.InvalidConfigName: Bad characters from black list '<>:/\|?*' found in 'card=cards.stsb[metrics:[metrics.accuracy]]'. They could create issues when creating a directory for this config on Windows filesystem.
9c84a26
to
38880e3
Compare
Thanks, @elronbandel , you mean the ":" is forbidden even it does not go to inside any name, only between names? |
b39a6c6
to
9550b32
Compare
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
9550b32
to
dbb4467
Compare
No description provided.