Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dicts in overwrite args of fetched artifact #598

Merged
merged 8 commits into from
Feb 28, 2024

Conversation

dafnapension
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 95.86207% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 88.55%. Comparing base (4802d98) to head (dbb4467).

Files Patch % Lines
src/unitxt/parsing_utils.py 94.39% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #598      +/-   ##
==========================================
+ Coverage   88.46%   88.55%   +0.09%     
==========================================
  Files          87       87              
  Lines        7779     7858      +79     
==========================================
+ Hits         6882     6959      +77     
- Misses        897      899       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@elronbandel elronbandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind hugginface forbid the use of this character in datasets query strings:
<>:/\|?*
Meaning you can not use the new syntax with : so if you can come up with syntax that can leave under this restriction it will be good. Also maybe we should add internally an assertion that forbid this characters in names and strings with a proper message that huggingface wont support it.

This is the hugginface error for reference:

datasets.builder.InvalidConfigName: Bad characters from black list '<>:/\|?*' found in 'card=cards.stsb[metrics:[metrics.accuracy]]'. They could create issues when creating a directory for this config on Windows filesystem.

@dafnapension
Copy link
Collaborator Author

dafnapension commented Feb 26, 2024

Thanks, @elronbandel , you mean the ":" is forbidden even it does not go to inside any name, only between names?
I will change to =
more intuitive in this jargon

@dafnapension dafnapension force-pushed the parse_traditionally branch 3 times, most recently from b39a6c6 to 9550b32 Compare February 28, 2024 07:52
@dafnapension dafnapension changed the title Can traditional parsing work? Allow dicts in overwrite args of fetched artifact Feb 28, 2024
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
@dafnapension dafnapension merged commit 3923a46 into main Feb 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants