Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtered ffqa dataset #593

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Add filtered ffqa dataset #593

merged 3 commits into from
Feb 28, 2024

Conversation

marukaz
Copy link
Contributor

@marukaz marukaz commented Feb 21, 2024

Add WikiQA-Free_Form_QA dataset, a long context QA dataset.
This dataset is formatted to be used in chat format, but I want to experiment with 8k context LLM, so I implemented preprocess_steps accordingly.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.46%. Comparing base (7b50122) to head (6ade2f1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #593   +/-   ##
=======================================
  Coverage   88.46%   88.46%           
=======================================
  Files          87       87           
  Lines        7779     7779           
=======================================
  Hits         6882     6882           
  Misses        897      897           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yoavkatz
Copy link
Member

@elronbandel - why does the catalog preparation this fail with:

image

@yoavkatz
Copy link
Member

The failure due to the fact that the this is merge from a fork. We will handle this.

@elronbandel
Copy link
Member

Issue is now fixed @marukaz . Notice i rebased your branch to re-run the tests.

Copy link
Member

@elronbandel elronbandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool contribution! This dataset will be very hard to incorpirate to unitxt without the creativity you showed with the ExcuteExpression! so thank you! If you can change the things i asked it will be great. let me know when your ready and ill merge.

marukaz and others added 2 commits February 27, 2024 09:18
Co-authored-by: Elron Bandel <elronbandel@gmail.com>
@marukaz
Copy link
Contributor Author

marukaz commented Feb 27, 2024

@elronbandel Thank you for your review! I updated code.

@marukaz
Copy link
Contributor Author

marukaz commented Feb 28, 2024

catalog preparation test is failing but when I tried python -m unittest discover -s tests/catalog -p "test_*.py" in my local it succeeded. I would like to rerun the test but I don't have the permission.

@elronbandel elronbandel merged commit 9b640fe into IBM:main Feb 28, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants