Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix artifact initialization dict creation to be recursive #559

Merged
merged 1 commit into from
Feb 6, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/unitxt/artifact.py
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ def verify(self):

@final
def __pre_init__(self, **kwargs):
self._init_dict = deepcopy(kwargs)
self._init_dict = deepcopy(get_raw(kwargs))

@final
def __post_init__(self):
Expand All @@ -232,6 +232,16 @@ def save(self, path):
save_json(path, data)


def get_raw(element):
if isinstance(element, Artifact):
return element._to_raw_dict()
if isinstance(element, (list, tuple)):
return [get_raw(sub_element) for sub_element in element]
if isinstance(element, dict):
return {key: get_raw(value) for key, value in element.items()}
return element


class ArtifactList(list, Artifact):
def prepare(self):
for artifact in self:
Expand Down
Loading