allow imports list for executequery and filterbyquery and rename to ExecuteExpression and FilterByExpression

[dafnapension]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fee7ec1) 93.94% compared to head (f389889) 93.94%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #542   +/-   ##
=======================================
  Coverage   93.94%   93.94%           
=======================================
  Files         211      211           
  Lines        8104     8104           
=======================================
  Hits         7613     7613           
  Misses        491      491           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[elronbandel]

I think AssignExpression might give the impression its just adding the expression as a field. I think that if the name was ExecuteExpression is it was more clear the expression is executed. what do you think @yoavkatz @dafnapension ?

[dafnapension]

No problem in renaming. I was not sure why the expression is more 'executed' in this operator than it is by FilterByExpression.
I thought that the difference between those two is by what you do with the value of the expression:
filter (by the computed expression) vs assign (the computed expression) to to_field.
The expression is actually 'executed' (i.e. computed) by the Mixin.

[elronbandel]

This is not good. as the imports_list here is assigned at the class level which means all the instances will forver use the same list

Can be fixed by first: from .dataclass import OptionalField

Then imports_list: List[str] = OptionalField(default_factory=list)

[dafnapension]

Done. I missed that..