Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add side effect operators that does not modify the stream like download and extract #523

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

elronbandel
Copy link
Member

No description provided.

@elronbandel elronbandel force-pushed the add_side_affect_operators_like_download_and_extract branch from 8d6b5e9 to 1615ccc Compare January 29, 2024 08:36
@elronbandel elronbandel changed the title Add side affect operators like download and extract Add side effect operators that does not modify the stream like download and extract Jan 29, 2024
@dafnapension dafnapension force-pushed the add_side_affect_operators_like_download_and_extract branch from 4b84705 to 0c4e732 Compare January 29, 2024 09:23
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (611442c) 94.08% compared to head (0c4e732) 93.78%.

❗ Current head 0c4e732 differs from pull request most recent head bf46ac3. Consider uploading reports for the commit bf46ac3 to get more accurate results

Files Patch % Lines
src/unitxt/operators.py 57.14% 12 Missing ⚠️
src/unitxt/operator.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
- Coverage   94.08%   93.78%   -0.30%     
==========================================
  Files         207      199       -8     
  Lines        7979     7922      -57     
==========================================
- Hits         7507     7430      -77     
- Misses        472      492      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ilyashnil and others added 4 commits January 30, 2024 15:40
Signed-off-by: ilyashn <ilyashn@il.ibm.com>
Signed-off-by: Elron Bandel <elron.bandel@ibm.com>
Signed-off-by: Elron Bandel <elron.bandel@ibm.com>
Signed-off-by: Elron Bandel <elron.bandel@ibm.com>
@elronbandel elronbandel force-pushed the add_side_affect_operators_like_download_and_extract branch from 0c4e732 to bf46ac3 Compare January 30, 2024 13:40
@elronbandel elronbandel merged commit afe2358 into main Jan 30, 2024
4 checks passed
@elronbandel elronbandel deleted the add_side_affect_operators_like_download_and_extract branch April 8, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants