Improve catalog UI on documentation website by separating catalog objects to files and adding information per catalog item #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #461 +/- ##
=======================================
Coverage 94.08% 94.08%
=======================================
Files 191 191
Lines 7814 7814
=======================================
Hits 7352 7352
Misses 462 462 ☔ View full report in Codecov by Sentry. |
matanor
force-pushed
the
organize_catalog
branch
from
ddd06ec
to
9890cda
Compare
docs/catalog.py
Outdated
| ) | ||
|
|
||
| def is_json(self): | ||
| return not self.is_dir and ".json" in self.rel_path |
There was a problem hiding this comment.
self.rel_path.endswith(".json") ?
matanor
force-pushed
the
organize_catalog
branch
from
5bd3ca0
to
0dc77d2
Compare
elronbandel
changed the title
add artifact type docstring
elronbandel
force-pushed
the
organize_catalog
branch
from
f4474f5
to
a24bd8b
Compare
elronbandel
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #460