Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perplexity #442

Merged
merged 10 commits into from
Jan 14, 2024
Merged

Perplexity #442

merged 10 commits into from
Jan 14, 2024

Conversation

assaftibm
Copy link
Member

No description provided.

Signed-off-by: Assaf Toledo <assaf.toledo@ibm.com>
Signed-off-by: Assaf Toledo <assaf.toledo@ibm.com>
@assaftibm assaftibm requested a review from matanor January 1, 2024 16:52
Copy link

codecov bot commented Jan 1, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (12cac48) 93.96% compared to head (56f33f9) 94.01%.

Files Patch % Lines
src/unitxt/metrics.py 94.93% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
+ Coverage   93.96%   94.01%   +0.04%     
==========================================
  Files         179      180       +1     
  Lines        7574     7699     +125     
==========================================
+ Hits         7117     7238     +121     
- Misses        457      461       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@assaftibm
Copy link
Member Author

The metric computes the likelihood of generating the text Y after the text X (i.e. P(Y|X))
There is no clear alignment between X and Y, and the notions of reference and prediction as used in Unitxt.
After consulting with Yosi Mass, we think it makes sense to treat them this way:

  • X = prediction
  • Y = reference.

Copy link
Member

@yoavkatz yoavkatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need to commit the json files.

Signed-off-by: Assaf Toledo <assaf.toledo@ibm.com>
@assaftibm
Copy link
Member Author

I think you also need to commit the json files.

I just pushed them now

@yoavkatz
Copy link
Member

Perhaps use this naming convention:

instead of
src/unitxt/catalog/metrics/perplexity/flan/t5/small.json

use
src/unitxt/catalog/metrics/perplexity/flan_t5_small.json

So there will be less directories.

Signed-off-by: Assaf Toledo <assaf.toledo@ibm.com>
Signed-off-by: Assaf Toledo <assaf.toledo@ibm.com>
Signed-off-by: Assaf Toledo <assaf.toledo@ibm.com>
@assaftibm
Copy link
Member Author

fixed

@assaftibm assaftibm merged commit e8560b9 into main Jan 14, 2024
6 checks passed
@assaftibm assaftibm deleted the perplexity branch January 14, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants