This repository has been archived by the owner on Jul 12, 2019. It is now read-only.
Change small margin to be a string #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Super pedantic but it breaks breakpoint types that expect margin to all to be the same type (string). Another option would be just using '0'
joshblack
suggested changes
Jan 30, 2019
Co-Authored-By: vpicone <vpicone@gmail.com>
|
Deploy preview for carbon-elements ready! Built with commit 0ebc053 |
|
Deploy preview for carbon-elements ready! Built with commit d0d8641 |
joshblack
approved these changes
Jan 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Super pedantic but it breaks breakpoint types that expect margin to all to be the same type (string). Another option would be just using '0'