fix(type): $expressive-heading-04 line height at mobile (#323)

* fix $expressive-heading-04 line height at mobile Line height should be the same at every breakpoint at Step 6 for $expressive-heading-04; it only changes when the type size changes at max breakpoint to step 7. * fix(type): update line-height in scss * chore(test): update snapshots
carbon-design-system · Feb 6, 2019 · f36a174 · f36a174
1 parent f43154a
commit f36a174
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/type/scss/_styles.scss b/packages/type/scss/_styles.scss
@@ -125,7 +125,7 @@ $expressive-heading-04: (
   font-family: carbon--font-family('sans'),
   font-size: type-scale(7),
   font-weight: carbon--font-weight('regular'),
-  line-height: 107%,
+  line-height: 129%,
   letter-spacing: 0,
   breakpoints: (
     xlg: (

diff --git a/packages/type/src/__tests__/__snapshots__/styles-test.js.snap b/packages/type/src/__tests__/__snapshots__/styles-test.js.snap
@@ -292,15 +292,15 @@ Object {
   "fontSize": "calc(1.75rem + 0 * ((100vw - 20rem) / 62))",
   "fontWeight": 400,
   "letterSpacing": 0,
-  "lineHeight": "107%",
+  "lineHeight": "129%",
 }
 `;
 
 exports[`styles expressiveHeading04 should be printable 2`] = `
 "font-family: 'IBM Plex Sans', 'Helvetica Neue', Arial, sans-serif;
 font-size: calc(1.75rem + 0 * ((100vw - 20rem) / 62));
 font-weight: 400;
-line-height: 107%;
+line-height: 129%;
 letter-spacing: 0;
 -@media- -(min--width-:- -8-2rem-): [object Object];
 -@media- -(min--width-:- -9-9rem-): [object Object];"

diff --git a/packages/type/src/styles.js b/packages/type/src/styles.js
@@ -127,7 +127,7 @@ export const expressiveHeading04 = fluid({
   fontFamily: fontFamilies.sans,
   fontSize: rem(scale[6]),
   fontWeight: fontWeights.regular,
-  lineHeight: '107%',
+  lineHeight: '129%',
   letterSpacing: 0,
   breakpoints: {
     xlg: {