From 3bc5d6b867f74481983bdccda3bd09a235a69681 Mon Sep 17 00:00:00 2001
From: sandeepsajan0 <sandeepsajan0@gmail.com>
Date: Mon, 17 Jul 2023 11:57:44 +0530
Subject: [PATCH] Add pending paf approvals to PAF detail page and pdf, and
 fixed Reviews section spacing

---
 .../application_projects/paf_export.html      |  4 +--
 .../project_approval_detail.html              | 28 +++++++++----------
 2 files changed, 15 insertions(+), 17 deletions(-)

diff --git a/hypha/apply/projects/templates/application_projects/paf_export.html b/hypha/apply/projects/templates/application_projects/paf_export.html
index 955ab811f6..ad608bbff6 100644
--- a/hypha/apply/projects/templates/application_projects/paf_export.html
+++ b/hypha/apply/projects/templates/application_projects/paf_export.html
@@ -119,8 +119,8 @@ <h1 class="title"> {{ org_name }}(Project Approval Form | <a href="{{ project_li
             <p><b> Approvals </b></p>
             {% if approvals %}
                 {% for approval in approvals %}
-                        <p><b>{{ approval.paf_reviewer_role.label }}</b>({{ approval.user.email }})</p>
-                        <p>{% if approval.approved %} "Approved" {% else %} "Not approved yet"{% endif %}</p>
+                        <p>{{ approval.paf_reviewer_role.label }} - {% if approval.approved %} Approved {% else %} Pending{% endif %}
+                            {% if approval.user %}({{ approval.user }}){% endif %}</p>
                 {% endfor %}
             {% else %}
                 <p>-</p>
diff --git a/hypha/apply/projects/templates/application_projects/project_approval_detail.html b/hypha/apply/projects/templates/application_projects/project_approval_detail.html
index 5e58297b7c..f87f9ea3e0 100644
--- a/hypha/apply/projects/templates/application_projects/project_approval_detail.html
+++ b/hypha/apply/projects/templates/application_projects/project_approval_detail.html
@@ -96,39 +96,37 @@ <h4>{% trans "Approvals" %}</h4>
                 <div class="card card--solid">
                     {% for approval in project.paf_approvals.all %}
                         {% if approval.approved %}
-                            <p><b>{{ approval.paf_reviewer_role.label }}</b>({{ approval.user }}) - {{ approval.approved_at|date:"DATE_FORMAT" }}</p>
+                            <p><b>{{ approval.paf_reviewer_role.label }}</b> - {{ approval.user }} ({{ approval.approved_at|date:"DATE_FORMAT" }})</p>
+                        {% else %}
+                            <p><b>{{ approval.paf_reviewer_role.label }}</b> {% trans " - Pending" %}</p>
                         {% endif %}
                     {% endfor %}
                 </div>
 
                 <h4>{% trans "Review" %}</h4>
                 <div class="card card--solid">
-                    <p class="font-bold">{% trans "Submission lead" %}</p>
-                    <p>{{ project.submission.lead }}</p>
+                    <p class="font-bold mb-0 mt-0">{% trans "Submission lead" %}</p>
+                    <p class="mt-2 mb-0">{{ project.submission.lead }}</p>
 
-                    <p class="font-bold">{% trans "Staff reviewers" %}</p>
+                    <p class="font-bold mt-6 mb-0">{% trans "Staff reviewers" %}</p>
                     {% for review in project.submission.reviews.by_staff %}
-                    <div class="card__reviewer-outcome">
-                        <span class="card__reviewer">
+                        <p class="mt-2 mb-0">
                             {{ review.author }}
                             {% if review.author.role %}
                                 {% trans "as" %} {{ review.author.role }}
                             {% endif %}
                             - {{ review.created_at|date:"DATE_FORMAT" }}
-                        </span>
-                    </div>
+                        </p>
                     {% empty %}
-                        <p>{% trans "No reviews" %}</p>
+                        <p class="mt-2 mb-0">{% trans "No reviews" %}</p>
                     {% endfor %}
-                    <p class="font-bold">{% trans "Advisory council" %}</p>
+                    <p class="font-bold mb-0 mt-6">{% trans "Advisory council" %}</p>
                     {% for review in project.submission.reviews.by_reviewers %}
-                        <div class="card__reviewer-outcome">
-                            <span class="card__reviewer">
+                            <p class="mt-2 mb-0">
                                 {{ review.author }} - {{ review.created_at|date:"DATE_FORMAT" }}
-                            </span>
-                        </div>
+                            </p>
                     {% empty %}
-                        <p>{% trans "No reviews" %}</p>
+                        <p class="mt-2 mb-0">{% trans "No reviews" %}</p>
                     {% endfor %}
                 </div>