Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate validation on Zod (replace AJV, Joi, and bespoke validators) #26

Open
4 tasks
Tracked by #552
carlgieringer opened this issue Jul 11, 2021 · 0 comments
Open
4 tasks
Tracked by #552
Labels
clean code Work to improve the codebase
Milestone

Comments

@carlgieringer
Copy link
Contributor

carlgieringer commented Jul 11, 2021

Remaining:

Related: figure out our API error response.

Now it's like:

{proposition: BespokeValidationErrors<Proposition>}

Perhaps we could do this instead:

  • z.ZodError<typeof Request> or
  • {error: z.ZodError<typeof Request>}
@carlgieringer carlgieringer added the clean code Work to improve the codebase label Jul 11, 2021
@carlgieringer carlgieringer added this to the P2 milestone Jul 11, 2021
@carlgieringer carlgieringer self-assigned this Oct 9, 2022
@carlgieringer carlgieringer changed the title Replace Joi with AJV Consolidate validation on AJV (replace Joi and bespoke validators) Oct 12, 2022
@carlgieringer carlgieringer changed the title Consolidate validation on AJV (replace Joi and bespoke validators) Consolidate validation on Zod (replace AJV, Joi, and bespoke validators) Dec 14, 2022
@carlgieringer carlgieringer removed their assignment Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean code Work to improve the codebase
Projects
Status: In Progress
Development

No branches or pull requests

1 participant