Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could a new official version be released? #828

Open
TheStormN opened this issue May 16, 2024 · 8 comments
Open

Could a new official version be released? #828

TheStormN opened this issue May 16, 2024 · 8 comments

Comments

@TheStormN
Copy link
Contributor

TheStormN commented May 16, 2024

The last release is from 2021 - version 3.0.1.

Could we have another release please? We are using package management system and using a git hash id from the master branch is possible, but it will be much easier to track versions if we have another public release.

P.S. Be sure to also update CMakeLists.txt with the latest version tag if a new release is issued.

@tinloaf
Copy link

tinloaf commented Jun 18, 2024

I especially think that the fix for #826 merits a new release. People who build with the latest compilers are currently unable to use a released version of this library.

@DDoS
Copy link

DDoS commented Jun 22, 2024

Yes please release a new version! If the library has been changed to "live at head" versioning, please let us know so I can update vcpkg to the new scheme.

@HowardHinnant
Copy link
Owner

I highly recommend "live at head". "head" is always kept in a shippable state.

That being said, I will try to get one last release out in the next week.

Chi-EEE added a commit to Chi-EEE/xmake-repo that referenced this issue Jul 10, 2024
waruqi pushed a commit to xmake-io/xmake-repo that referenced this issue Jul 11, 2024
* date: fix package

Links were missing to run this package

* date: change versioning

HowardHinnant/date#828 (comment)

* date: use c++11 for test

* date: add_syslinks("z") for macosx

* date: add_deps("zlib") for macosx

* date: add_frameworks("Foundation") for macosx & iphoneos
@basilgello
Copy link
Contributor

Bark bark :)

I would really like to skip 50 patches from kodi source tree just because the version is not tagged :(

@HowardHinnant
Copy link
Owner

I hear you. Giving the parsing fixes some time to gel. And trying to find time to review the most critical PR's first. And I'm technically unable to review those PR's which involve make files.

Or I could just tag master as is...

@basilgello
Copy link
Contributor

basilgello commented Sep 17, 2024

I can help you with make and cmake if needed. Just tag me on PRs you need help with!

@HowardHinnant
Copy link
Owner

I'll take it. Any PR tagged with CMake is yours.

@basilgello
Copy link
Contributor

basilgello commented Sep 28, 2024

I managed to complete xbmc/xbmc#18727 and getting back here as promised last week:

Other patches are stale for many years :)

And I would like to add my patch that allows using Android's compiled tzdata. This should be safe as modern Android versions ship updatable tzdata in APEX (Android Pone EXpress) format via Google Play.

The only concern regards this patch is that it adds new public method void time_zone::parse_from_android_tzdata(std::ifstream& inf, const std::size_t off) that in fact must be private as it is used only by date::init_tzdb and is not supposed for external consumption. I guess it can be solved by fiddling with friend classes but I hope someone more knowledgeable in C++ suggests an elegant solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants