From 85bbaa5aeaae786e9e73ab02048288c083b8b539 Mon Sep 17 00:00:00 2001 From: Vladimir Dvorak Date: Mon, 2 Sep 2024 19:04:17 +0200 Subject: [PATCH] Change log level info->debug in obvious cases in SpringPlugin --- .../agent/plugin/spring/core/BeanFactoryProcessor.java | 4 ++-- .../agent/plugin/spring/getbean/DetachableBeanHolder.java | 4 ++-- .../agent/plugin/spring/reload/SpringBeanReload.java | 8 ++++---- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/plugin/hotswap-agent-spring-plugin/src/main/java/org/hotswap/agent/plugin/spring/core/BeanFactoryProcessor.java b/plugin/hotswap-agent-spring-plugin/src/main/java/org/hotswap/agent/plugin/spring/core/BeanFactoryProcessor.java index fb751411..e4191911 100644 --- a/plugin/hotswap-agent-spring-plugin/src/main/java/org/hotswap/agent/plugin/spring/core/BeanFactoryProcessor.java +++ b/plugin/hotswap-agent-spring-plugin/src/main/java/org/hotswap/agent/plugin/spring/core/BeanFactoryProcessor.java @@ -61,7 +61,7 @@ public static void postProcessDestroySingleton(DefaultSingletonBeanRegistry bean // check if reload , then log if (beanFactory instanceof ConfigurableListableBeanFactory && BeanFactoryAssistant.getBeanFactoryAssistant((ConfigurableListableBeanFactory)beanFactory).isReload()) { - LOGGER.info("destroy bean '{}' from '{}'", beanName, ObjectUtils.identityToString(beanFactory)); + LOGGER.debug("destroy bean '{}' from '{}'", beanName, ObjectUtils.identityToString(beanFactory)); } if (beanFactory instanceof BeanFactoryLifecycle) { ((BeanFactoryLifecycle)beanFactory).hotswapAgent$destroyBean(beanName); @@ -80,7 +80,7 @@ public static void postProcessCreateBean(AbstractAutowireCapableBeanFactory bean if (beanFactory instanceof ConfigurableListableBeanFactory && BeanFactoryAssistant.getBeanFactoryAssistant((ConfigurableListableBeanFactory)beanFactory).isReload() && mbd.isSingleton()) { - LOGGER.info("create new singleton bean '{}' from '{}'", beanName, + LOGGER.debug("create new singleton bean '{}' from '{}'", beanName, ObjectUtils.identityToString(beanFactory)); } } diff --git a/plugin/hotswap-agent-spring-plugin/src/main/java/org/hotswap/agent/plugin/spring/getbean/DetachableBeanHolder.java b/plugin/hotswap-agent-spring-plugin/src/main/java/org/hotswap/agent/plugin/spring/getbean/DetachableBeanHolder.java index 9daffc78..fbc560ed 100644 --- a/plugin/hotswap-agent-spring-plugin/src/main/java/org/hotswap/agent/plugin/spring/getbean/DetachableBeanHolder.java +++ b/plugin/hotswap-agent-spring-plugin/src/main/java/org/hotswap/agent/plugin/spring/getbean/DetachableBeanHolder.java @@ -83,7 +83,7 @@ public static void detachBeans() { } } if (i > 0) { - LOGGER.info("{} Spring proxies reset", i); + LOGGER.debug("{} Spring proxies reset", i); } else { LOGGER.debug("No spring proxies reset"); } @@ -144,7 +144,7 @@ public Object getBean() throws IllegalAccessException, InvocationTargetException LOGGER.debug("Bean of '{}' not loaded, {} ", bean.getClass().getName(), paramValues); break; } - LOGGER.info("Bean '{}' loaded", bean.getClass().getName()); + LOGGER.debug("Bean '{}' loaded", bean.getClass().getName()); break; } } diff --git a/plugin/hotswap-agent-spring-plugin/src/main/java/org/hotswap/agent/plugin/spring/reload/SpringBeanReload.java b/plugin/hotswap-agent-spring-plugin/src/main/java/org/hotswap/agent/plugin/spring/reload/SpringBeanReload.java index 7cff232b..c92e6602 100644 --- a/plugin/hotswap-agent-spring-plugin/src/main/java/org/hotswap/agent/plugin/spring/reload/SpringBeanReload.java +++ b/plugin/hotswap-agent-spring-plugin/src/main/java/org/hotswap/agent/plugin/spring/reload/SpringBeanReload.java @@ -95,9 +95,9 @@ public void addClass(Class clazz) { synchronized (classes) { if (classes.add(clazz)) { if (sameClass) { - LOGGER.info("try to add changed class '{}' into {}", clazz.getName(), ObjectUtils.identityToString(beanFactory)); + LOGGER.debug("try to add changed class '{}' into {}", clazz.getName(), ObjectUtils.identityToString(beanFactory)); } else { - LOGGER.info("try to add changed class '{}({})' into {}", clazz.getName(), userClassSimpleName, ObjectUtils.identityToString(beanFactory)); + LOGGER.debug("try to add changed class '{}({})' into {}", clazz.getName(), userClassSimpleName, ObjectUtils.identityToString(beanFactory)); } } else { if (sameClass) { @@ -252,7 +252,7 @@ public boolean reload(long changeTimeStamps) { try { origContextClassLoader = ClassUtils.overrideThreadContextClassLoader(beanFactory.getBeanClassLoader()); beanFactoryAssistant.setReload(true); - LOGGER.info("##### start reloading '{}' with timestamp '{}'", ObjectUtils.identityToString(beanFactory), changeTimeStamps); + LOGGER.debug("##### start reloading '{}' with timestamp '{}'", ObjectUtils.identityToString(beanFactory), changeTimeStamps); LOGGER.trace("SpringReload:{}, beanFactory:{}", this, beanFactory); BeanFactoryProcessor.setAllowBeanDefinitionOverriding(beanFactory, true); do { @@ -263,7 +263,7 @@ public boolean reload(long changeTimeStamps) { ClassUtils.overrideThreadContextClassLoader(origContextClassLoader); beanFactoryAssistant.increaseReloadTimes(); BeanFactoryProcessor.setAllowBeanDefinitionOverriding(beanFactory, allowBeanDefinitionOverriding); - LOGGER.info("##### [{}th] finish reloading '{}', it cost {}ms", beanFactoryAssistant.getReloadTimes(), + LOGGER.debug("##### [{}th] finish reloading '{}', it cost {}ms", beanFactoryAssistant.getReloadTimes(), ObjectUtils.identityToString(beanFactory), System.currentTimeMillis() - now); } }