-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
Conversation
Test bot run failed on two OSes with errors like this.
Looks like an internal Jenkins error. Let's just rerun it. @BrewTestBot test this please |
Hmmm. Same failure to read test results on Yosemite and El Capitan. Looks like maybe something is producing invalid UTF-8 in its output?
Any other maintainers know if we can grab that |
It'll just "fail" repeatedly. The build itself is fine, otherwise Jenkins would red rather than yellow flag it. This is quite a well known Jenkins issue. The last time it was discussed @MikeMcQuaid was familiar with it but had forgotten how to hunt/resolve the issue, and given it's only a cosmetic problem we've more or less ignored it since. |
@apiri Stuff like that should be resolved by a regex like this: https://github.com/Homebrew/homebrew/blob/6c12be4db8434effc805b16bd6dc96f7c804bef2/Library/Homebrew/cmd/test-bot.rb#L920-L921 I'm 100% sure there's a better way of doing this so if you felt like it I'd be very grateful (you seem to be good at similar ratholes 😀) |
Yes, there is. According to http://stackoverflow.com/a/28152666 and http://stackoverflow.com/a/14323524, we should filter string based on XML spec. i.e. output = step.output.gsub(/[^\x09\x0A\x0D\x20-\uD7FF\uE000-\uFFFD\u10000-\u10FFFF]/, "") |
@MikeMcQuaid you got the wrong ap*! :) I think he is far better at those problems than myself. |
@xu-cheng could you try a PR for that? Seems like the idea solution 👍 |
@apiri sorry! |
@yous, what's the status here? Akka 2.4.4 seems to be out by now and I suspect we're better off creating a new pull request in Homebrew/homebrew-core, right? (The Jenkins issues that had previously plagued this PR should be resolved by now.) |
@UniqMartin Thanks for the bump. I made a new pull request Homebrew/homebrew-core#790, so closing this. |
@yous Awesome, thanks! |
Bump akka to 2.4.2.
brew install <formula>
?brew tests
with your changes locally?