Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bareos-client: update and fix build on Linux #99600

Closed
wants to merge 1 commit into from

Conversation

danielnachun
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added no ARM bottle Formula has no ARM bottle no Linux bottle Formula has no Linux bottle labels Apr 19, 2022
@danielnachun
Copy link
Member Author

I'm not sure why we were on such an old version before, though it appears that upstream may be supporting multiple major versions simultaneously.

I had to disable building the Python bindings because they try to install into the python@3.10 keg instead of the formula's own keg, which will fail due to lack of permissions (as intended). I believe this was not a problem before either because the bindings were automatically disabled, or used the system Python 2 and installed somewhere it had permission to modify.

@cho-m
Copy link
Member

cho-m commented Apr 19, 2022

I have a PR to update and fix Apple Silicon & Linux build in #98016, though with only bare feature set.

Was still pending on fixing static linkage to readline and need to look into upstreaming inreplaces for ARM's non-default prefix.

I had also disabled Python due to lacking any option to remove Python2 without patching build scripts.

@danielnachun
Copy link
Member Author

I'll close this for now!

@cho-m
Copy link
Member

cho-m commented Apr 19, 2022

I can try merging some of your changes, though may need extra inreplaces since upstream keeps forcing static libraries on macOS like lzo (https://github.com/bareos/bareos/blob/Release/21.1.2/core/cmake/BareosFindAllLibraries.cmake#L187)

If I had to guess, Python 3.10 issue may be related to prefix scheme change that is not present in Python 3.9 and older. I can try taking a look after patching out Python 2 code, which is causing issues for my local Monterey testing.

@danielnachun danielnachun deleted the bareos-client branch April 21, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no ARM bottle Formula has no ARM bottle no Linux bottle Formula has no Linux bottle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants