Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qmmp 2.0.4 #98439

Closed
wants to merge 1 commit into from
Closed

qmmp 2.0.4 #98439

wants to merge 1 commit into from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Apr 2, 2022

Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` no Linux bottle Formula has no Linux bottle labels Apr 2, 2022
@cho-m
Copy link
Member Author

cho-m commented Apr 2, 2022

Linux still needs projectm to attempt bottling. Will try bottling in #98440

@danielnachun
Copy link
Member

I think this will also need musepack, whose bottling status on Linux is still uncertain: #96781.

@cho-m
Copy link
Member Author

cho-m commented Apr 2, 2022

I think this will also need musepack, whose bottling status on Linux is still uncertain: #96781.

I moved musepack to macOS dependency. If it complains, we can force disable via -DUSE_MPC

@cho-m cho-m added the ready to merge PR can be merged once CI is green label Apr 3, 2022
@cho-m
Copy link
Member Author

cho-m commented Apr 3, 2022

Rebased to see Linux build. Guessing it may fail due to -Wl,-undefined,dynamic_lookup.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@cho-m cho-m deleted the bump-qmmp-2.0.4 branch April 4, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` no Linux bottle Formula has no Linux bottle ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cho-m @danielnachun @BrewTestBot @chenrui333