bareos-client 21.1.3 #98016
bareos-client 21.1.3 #98016
Conversation
BrewTestBot
added
bump-formula-pr
cho-m
force-pushed
the
bump-bareos-client-21.1.2
branch
from
aabb287
to
fe61fcf
Compare
Formula/bareos-client.rb
Outdated
| system "make", "install" | ||
| end | ||
| args = %W[ | ||
| -DENABLE_PYTHON=OFF |
There was a problem hiding this comment.
No idea how to only disable Python 2.
bareos-client uses find_package(Python2 ...) and find_package(Python3 ...). - https://github.com/bareos/bareos/blob/Release/21.1.2/core/cmake/BareosFindAllLibraries.cmake#L45-L46
MacOS Python 2 causes issues during install.
There was a problem hiding this comment.
Could we just inreplace "Python2", "Python3"?
There was a problem hiding this comment.
Even manually disabling Python 2 causes other failures with Python 3 as it tries to install into Python formula Framework directory. For now, will drop Python plugins. Build system isn't really friendly to 3rd-party distribution.
cho-m
force-pushed
the
bump-bareos-client-21.1.2
branch
2 times, most recently
from
378c9c7
to
ac05771
Compare
Formula/bareos-client.rb
Outdated
| end | ||
| # Work around hardcoded paths to /usr/local Homebrew installation | ||
| inreplace "core/CMakeLists.txt", "/usr/local/", "#{HOMEBREW_PREFIX}/" | ||
| inreplace "core/cmake/FindReadline.cmake", "/usr/local/opt/readline/lib", Formula["readline"].opt_lib |
There was a problem hiding this comment.
Hardcoded path to readline static library (/usr/local/opt/readline/lib/libreadline.a) in https://github.com/bareos/bareos/blob/Release/21.1.2/core/cmake/FindReadline.cmake#L32=
Could just remove the Darwin section and let CMake find_library properly detect the dylib. Otherwise, this isn't actually using readline at runtime for macos.
There was a problem hiding this comment.
I'd suggest removing the Darwin section indeed
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a |
cho-m
added
in progress
cho-m
force-pushed
the
bump-bareos-client-21.1.2
branch
from
ac05771
to
7de4c9f
Compare
cho-m
force-pushed
the
bump-bareos-client-21.1.2
branch
2 times, most recently
from
c4bb655
to
c35cb70
Compare
cho-m
force-pushed
the
bump-bareos-client-21.1.2
branch
from
c35cb70
to
e6ec5f7
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a |
cho-m
added
ready to merge
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a |
|
🤖 A scheduled task has triggered a merge. |
Created with
brew bump-formula-pr.