Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subversion@1.8: deprecate #97742

Closed
wants to merge 2 commits into from

Conversation

Moisan
Copy link
Member

@Moisan Moisan commented Mar 25, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Follow-up of #67350

Related to #93940

@BrewTestBot BrewTestBot added formula deprecated Formula deprecated legacy Relates to a versioned @ formula no Linux bottle Formula has no Linux bottle labels Mar 25, 2022
@carlocab carlocab added the CI-no-bottles Merge without publishing bottles label Mar 25, 2022
@@ -16,6 +16,8 @@ class SubversionAT18 < Formula

keg_only :versioned_formula

deprecate! date: "2020-12-21", because: :versioned_formula
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we make this :does_not_build since scons is on Python 3 but this formula needs Python 2, making it impossible to build in Homebrew.

@cho-m cho-m added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Mar 26, 2022
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@Moisan Moisan deleted the subversion@1.8_deprecate branch March 27, 2022 14:41
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-bottles Merge without publishing bottles CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula deprecated Formula deprecated legacy Relates to a versioned @ formula no Linux bottle Formula has no Linux bottle outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants