Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ship: deprecate #97741

Merged
merged 2 commits into from
Mar 26, 2022
Merged

ship: deprecate #97741

merged 2 commits into from
Mar 26, 2022

Conversation

Moisan
Copy link
Member

@Moisan Moisan commented Mar 25, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Related to #93940

I used the date of the commit announcing the supersede of ship by kots.

@BrewTestBot BrewTestBot added formula deprecated Formula deprecated go Go use is a significant feature of the PR or issue no Linux bottle Formula has no Linux bottle nodejs Node or npm use is a significant feature of the PR or issue labels Mar 25, 2022
@Moisan Moisan mentioned this pull request Mar 25, 2022
Closed
46 tasks
@carlocab carlocab added the CI-no-bottles Merge without publishing bottles label Mar 25, 2022
carlocab
carlocab reviewed Mar 25, 2022
View reviewed changes
Formula/ship.rb Outdated
@@ -15,6 +15,9 @@ class Ship < Formula
sha256 cellar: :any_skip_relocation, mojave: "c3974dea38bf106223fc9bccb8c3e2eaff6f8d951a95ddad849a63edc6040578"
end

# depends indirectly on python@2 and is superseded by kots
deprecate! date: "2019-11-22", because: :deprecated_upstream
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use today's date. That will make it easier to work out when this can be disabled.

@carlocab carlocab merged commit 0af0019 into Homebrew:master Mar 26, 2022
@Moisan Moisan deleted the ship_deprecate branch March 27, 2022 01:21
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
CI-no-bottles Merge without publishing bottles formula deprecated Formula deprecated go Go use is a significant feature of the PR or issue no Linux bottle Formula has no Linux bottle nodejs Node or npm use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Moisan @carlocab @BrewTestBot