Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cppcms: use brewed python #97007

Closed
wants to merge 1 commit into from

Conversation

alebcay
Copy link
Member

@alebcay alebcay commented Mar 16, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Part of #93940. Unlike described in that issue, there's actually a runtime dependency on Python (albeit a small one). There's a Python script installed in bin, cppcms_tmpl_cc.

For now, I'm doing this is as CI-no-bottles. There is indeed a difference in the Python script that is shipped, but it's not exactly a main part of the package. Moreover, the script should continue working on existing installations (where Python 2 is present - except for folks upgrading to Monterey 12.3, I suppose). The upside is that we can keep old bottles. This should also work on Linux now. Open to discussion/making this a full revision/rebuild.

@alebcay alebcay added the CI-no-bottles Merge without publishing bottles label Mar 16, 2022
@BrewTestBot BrewTestBot added missing license Formula has a missing license which should be added no Linux bottle Formula has no Linux bottle python Python use is a significant feature of the PR or issue labels Mar 16, 2022
@@ -24,11 +26,25 @@ class Cppcms < Formula
depends_on "cmake" => :build
depends_on "openssl@1.1"
depends_on "pcre"
depends_on "python@3.10"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a runtime dependency we should publish new bottles.

@carlocab carlocab removed the CI-no-bottles Merge without publishing bottles label Mar 16, 2022
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
missing license Formula has a missing license which should be added no Linux bottle Formula has no Linux bottle outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants