Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

musepack: enable installation on linux #96781

Closed
wants to merge 1 commit into from
Closed

musepack: enable installation on linux #96781

wants to merge 1 commit into from

Conversation

reishoku
Copy link
Contributor

Signed-off-by: KOSHIKAWA Kenichi <reishoku.misc @ pm.me>

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@reishoku reishoku changed the title musepack: enable installation for linux musepack: enable installation on linux Mar 13, 2022
@BrewTestBot BrewTestBot added missing license Formula has a missing license which should be added no Linux bottle Formula has no Linux bottle labels Mar 13, 2022
Signed-off-by: KOSHIKAWA Kenichi <reishoku.misc@pm.me>
@cho-m
Copy link
Member

cho-m commented Mar 13, 2022

See previous (unmerged) PR #92041 for changes needed to build.

Comment from @iMichka on maintenance status still holds.

Comment on lines +36 to +40
if OS.mac?
lib.install "libmpcdec/libmpcdec.dylib"
else
lib.install "libmpcdec/libmpcdec.so"
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if OS.mac?
lib.install "libmpcdec/libmpcdec.dylib"
else
lib.install "libmpcdec/libmpcdec.so"
end
lib.install "libmpcdec/#{shared_library("libmpcdec")}"

Here's a more compact way of writing this.

It's not enough, unfortunately: #92041

@carlocab carlocab added the CI-no-bottles Merge without publishing bottles label Mar 13, 2022
@danielnachun danielnachun mentioned this pull request Apr 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Apr 3, 2022
@github-actions github-actions bot closed this Apr 10, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label May 11, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-bottles Merge without publishing bottles missing license Formula has a missing license which should be added no Linux bottle Formula has no Linux bottle outdated PR was locked due to age stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants