Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spidermonkey: depend on python@3.10 #94820

Closed
wants to merge 1 commit into from

Conversation

branchvincent
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

For #93940

@BrewTestBot BrewTestBot added no ARM bottle Formula has no ARM bottle no Linux bottle Formula has no Linux bottle labels Feb 10, 2022
Formula/spidermonkey.rb Outdated Show resolved Hide resolved
@branchvincent branchvincent added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Feb 10, 2022
@branchvincent
Copy link
Member Author

.../js/src/methodjit/MethodJIT.cpp:192:5: error: meaningless 'volatile' on asm outside function

@cho-m
Copy link
Member

cho-m commented Feb 10, 2022

I wonder if this version is too old now since it has been around for over 10+ years. Could be some updates to Apple Clang.

Ideally, we would retry updating like in #78997. The problem is going to be couchdb, which will require a versioned copy of spidermonkey. May consider using a resource there since the spidermonkey version should be updated along with couchdb whenever possible.


EDIT: We actually do use v78 resource in gjs (though the lack of Monterey bottle is worrisome as it may mean it has same issue). Anyway, may be worth seeing if possible to refactor formulae/dependencies/resources a bit similar to Arch https://archlinux.org/packages/extra/x86_64/js78/

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Mar 4, 2022
@cho-m
Copy link
Member

cho-m commented Mar 7, 2022

So spidermonkey should now be updated to newer version v91 with Python 3 in #94905.

One thing that needs to be revisited is that I used python@3.9 rather than python@3.10 due to error:

==> ../configure --prefix=/usr/local/Cellar/spidermonkey@91/91.6.0 --enable-optimize --enable-readline ...
Last 15 lines from /Users/cho-m/Library/Logs/Homebrew/spidermonkey@91/02.configure:
  File "/private/tmp/spidermonkeyA91-20220210-6205-qg8q9a/firefox-91.6.0/python/mozbuild/mozbuild/util.py", line 1050, in method_call
    cache[args] = self.func(instance, *args)

   ...

  File "/private/tmp/spidermonkeyA91-20220210-6205-qg8q9a/firefox-91.6.0/python/mozbuild/mozbuild/virtualenv.py", line 615, in _disable_pip_outdated_warning
    with open(os.path.join(site_packages, pip_dist_info, "INSTALLER"), "w") as file:
PermissionError: [Errno 1] Operation not permitted: '/usr/local/lib/python3.10/site-packages/pip-22.0.2.dist-info/INSTALLER'

This is probably a side-effect of how we set up python@3.10 since Linux distros are able to use latest Python

@github-actions github-actions bot removed the stale No recent activity label Mar 7, 2022
@cho-m cho-m added the superseded PR was replaced by another PR label Mar 7, 2022
@cho-m
Copy link
Member

cho-m commented Mar 7, 2022

Closing for now. Can reopen if you want to work on python@3.9 --> python@3.10 update.

@cho-m cho-m closed this Mar 7, 2022
@branchvincent branchvincent deleted the spidermonkey branch March 23, 2022 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. no ARM bottle Formula has no ARM bottle no Linux bottle Formula has no Linux bottle superseded PR was replaced by another PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants