spidermonkey 89.0 #78997

paperchalice · 2021-06-09T03:59:24Z

Have you followed the guidelines for contributing?
Have you ensured that your commits follow the commit style guide?
Have you checked that there aren't other open pull requests for the same formula update/change?
Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

From https://archive.mozilla.org/pub/spidermonkey/README.txt

We have stopped uploading specific releases. SpiderMonkey source packages are
not an official Mozilla product, though we do try to keep them working.
https://github.com/mozilla-spidermonkey/spidermonkey-embedding-examples is the
best source of information for these releases, though you will also want to
visit the main SpiderMonkey documentation page at https://spidermonkey.dev/
The easiest way to fetch the version corresponding to the current Firefox
release is to visit the treeherder page for the release repository and click on
the first SM(pkg) link you see. That will open a small window in the bottom
left with a line like
artifact uploaded: mozjs-86.0.1.tar.xz
where the 'mozjs-*.tar.xz' part will be a link to the actual file.
For the SpiderMonkey package corresponding to the current Firefox release:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-release&filter-searchStr=spidermonkey-sm-package
For the SpiderMonkey package corresponding to the latest ESR (Extended Support
Release), select "Repos" from the above page and choose the latest
"mozilla-esrNN" repository, then follow the instructions above. For example,
for esr78 that would take you to:
https://treeherder.mozilla.org/jobs?repo=mozilla-esr78&filter-searchStr=spidermonkey-sm-package
Build instructions are in a toplevel INSTALL file.
To contact us via various mechanisms (realtime chat, forum, mailing list, etc.)
see the "Where to find us" section at https://spidermonkey.dev/

The version number here follows firefox.

remove libjs_static.ajs because https://www.linuxfromscratch.org/blfs/view/svn/general/js78.html

Formula/couchdb.rb

carlocab · 2021-06-10T10:05:20Z

Formula/couchdb.rb

+         {
+             "-DXP_UNIX -I/usr/include/mozjs-60 -I/usr/local/include/mozjs-60 -std=c++14 -Wno-invalid-offsetof",
+-            "-L/usr/local/lib -std=c++14 -lmozjs-60 -lm"
+            "-L/usr/local/lib -std=c++14 -lmozjs-60 -lm -lstdc++"


This might explain why using llvm didn't work, btw. If we want to use llvm this should probably be -lc++. In fact, it might work with Xcode Clang on Catalina/Big Sur if we just made this -lc++ -stdlib=libc++

This seems like a template related issue, here we use spidermonky 78, the standard library is not specified in this case, btw, gcc support c++20 better than clang currently.

CC @Bo98 in case you have thoughts on this.

paperchalice · 2021-06-10T10:48:09Z

I think I should create versioned formulae for spidermonkey. One for firefox ESR, now is 78.x, one for 1.8.5, the last version of spidermonkey before mozilla stopping shipping spidermonkey separately , because couchdb 3.1.1 only support spidermonkey 1.8.5, 60 and 68(depends on python2 and llvm 3.9~6.0) if without patching, and one for the latest.
BTW gjs can also depends on spidermonkey
This formula is called js78 or libmozjs in other Linux distributions.

paperchalice · 2021-06-12T03:32:12Z

Firefox support apple silicon since 84 https://support.mozilla.org/en-US/kb/upgrading-new-version-firefox-84-apple-silicon
Next esr is 91 https://wiki.mozilla.org/Release_Management/Calendar

carlocab · 2021-06-19T13:33:39Z

Formula/couchdb.rb

@@ -92,3 +117,90 @@ def plist
    assert_equal "Welcome", output["couchdb"]
  end
 end
+


Suggested change

carlocab · 2021-06-19T13:34:11Z

Formula/spidermonkey.rb


-  conflicts_with "narwhal", because: "both install a js binary"
+  uses_from_macos "libedit"


Why not use readline?

There is a libreadline in sdk

I'm aware of that, but I'm not sure that explains why we should change it...

carlocab · 2021-06-19T13:34:57Z

Formula/spidermonkey@78.rb

@@ -0,0 +1,60 @@
+class SpidermonkeyAT78 < Formula


I still don't understand why we need this. Didn't couchdb build with spidermonkey 89?

Supported version is hard-coded here

carlocab · 2021-06-20T11:44:02Z

Formula/spidermonkey.rb

@@ -20,49 +21,52 @@ class Spidermonkey < Formula
    sha256 cellar: :any, mojave:   "8c0b46bc04a7e95f99262969b22cc311ee1f7d83413af05865318743ccd96944"
  end

-  depends_on :macos # Due to Python 2
+  depends_on "autoconf@2.13" => :build


Why doesn't this work with autoconf or autoconf@2.69?

Mozilla project requires autoconf 2.13 https://bugzilla.mozilla.org/show_bug.cgi?id=297544

Ah, yes. gjs also depends on autoconf 2.13.

carlocab · 2021-06-20T11:45:46Z

Formula/spidermonkey.rb

+    inreplace "config/rules.mk",
+              "-install_name $(_LOADER_PATH)/$(SHARED_LIBRARY) ",
+              "-install_name #{lib}/$(SHARED_LIBRARY) "


Are you sure we still need this? If it's using @loader_path it might work for us now.

This is copied from formular gjs. I'm not sure whether this formula needs this

github-actions · 2021-07-12T00:08:06Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

BrewTestBot added no ARM bottle Formula has no ARM bottle python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue labels Jun 9, 2021

paperchalice force-pushed the spidermonkey branch 5 times, most recently from 23f6998 to f8ad41f Compare June 10, 2021 03:01