Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snowpack: build with node@18 #127365

Merged
merged 2 commits into from
Apr 8, 2023
Merged

snowpack: build with node@18 #127365

merged 2 commits into from
Apr 8, 2023

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Apr 2, 2023

Fixes bottling on Ventura
Fixes:
npm ERR! gyp ERR! stack TypeError: Cannot assign to read only property 'cflags' of object '#'

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the nodejs Node or npm use is a significant feature of the PR or issue label Apr 2, 2023
@iMichka iMichka force-pushed the snowpack branch 3 times, most recently from 2fda09a to e4a3873 Compare April 5, 2023 20:07
@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Apr 5, 2023
@chenrui333 chenrui333 added the CI-requeued PR has been re-added to the queue label Apr 8, 2023
chenrui333
chenrui333 previously approved these changes Apr 8, 2023
@chenrui333
Copy link
Member

looks good now.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2023

🤖 A scheduled task has requested bottles to be published to this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2023

⚠️ Bottle publish failed.

@BrewTestBot BrewTestBot dismissed chenrui333’s stale review April 8, 2023 16:58

bottle publish failed

iMichka and others added 2 commits April 9, 2023 02:45
Fixes bottling on Ventura
Fixes:
npm ERR! gyp ERR! stack TypeError: Cannot assign to read only property 'cflags' of object '#<Object>'
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Apr 8, 2023
@ZhongRuoyu
Copy link
Member

@ZhongRuoyu ZhongRuoyu added CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. and removed CI-requeued PR has been re-added to the queue automerge-skip `brew pr-automerge` will skip this pull request labels Apr 8, 2023
@ZhongRuoyu ZhongRuoyu added this pull request to the merge queue Apr 8, 2023
Merged via the queue into Homebrew:master with commit 70d4c35 Apr 8, 2023
@iMichka iMichka deleted the snowpack branch April 8, 2023 19:54
@github-actions github-actions bot added the outdated PR was locked due to age label May 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. nodejs Node or npm use is a significant feature of the PR or issue outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants