Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omega-rpg: update urls, remove livecheck #123647

Closed
wants to merge 1 commit into from

Conversation

samford
Copy link
Member

@samford samford commented Feb 19, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

omega-rpg was deprecated in #123330, as the website has disappeared. This PR updates the homepage and stable URLs to use the most recent archive.org snapshots of each.

This also removes the livecheck block, so the formula will be automatically skipped as deprecated.

@samford samford added livecheck Issues or PRs related to livecheck CI-no-bottles Merge without publishing bottles labels Feb 19, 2023
@BrewTestBot BrewTestBot added formula deprecated Formula deprecated missing license Formula has a missing license which should be added labels Feb 19, 2023
@samford
Copy link
Member Author

samford commented Feb 19, 2023

The build appears to be broken on Linux in some way:

gcc-11  omega.o abyss.o aux1.o aux2.o aux3.o char.o city.o command1.o command2.o command3.o country.o effect1.o effect2.o effect3.o etc.o env.o file.o gen1.o gen2.o guild1.o guild2.o house.o init.o inv.o item.o itemf1.o itemf2.o itemf3.o lev.o mmelee.o mmove.o mon.o move.o movef.o mspec.o mstrike.o mtalk.o priest.o save.o scr.o site1.o site2.o spell.o time.o trap.o util.o village.o -lncurses -ltermcap -o omega
/usr/bin/ld: abyss.o:(.bss+0x0): multiple definition of `Omegalib'; omega.o:(.bss+0x7a80): first defined here
[...omitted similar messages for the other files]
collect2: error: ld returned 1 exit status
make: *** [Makefile:39: omega] Error 1

Considering that the formula is deprecated and the sha256 is the same for the tarball snapshot on archive.org, how do we feel about just running this PR as syntax-only?

@p-linnane p-linnane added CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. and removed CI-no-bottles Merge without publishing bottles labels Feb 19, 2023
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@samford samford deleted the omega-rpg-update-urls branch February 19, 2023 17:28
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula deprecated Formula deprecated livecheck Issues or PRs related to livecheck missing license Formula has a missing license which should be added outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants