aws-sso-util: fix build without dependency on cmake or rust #118910
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrewTestBot
added
the
python
cho-m
commented
Dec 25, 2022
Comment on lines
+34
to
+37
| # Use poetry_core backend to avoid unnecessary cmake and rust build dependencies. | ||
| # Remove when release uses aws-error-utils>=2.6. | ||
| # Backport of https://github.com/benkehoe/aws-error-utils/commit/f23a4bb8703e8ffabf1d008e04495572cc12d4ee | ||
| patch :DATA |
There was a problem hiding this comment.
One demerit is patch may break brew bump logic.
Other options are:
- Add
cmake(and keeprust) dependency. Demerit is these are probably unnecessary. - Use
poetryas dependency and manually run build command. Demerit is that we cannot usevirtualenv_install_with_resourcesDSL which makes it harder to maintain.
There was a problem hiding this comment.
maybe we should also file a PR to update aws-sso-util to use aws-error-utils>=2.6
I see, it is just not released yet.
Closed
p-linnane
approved these changes
Dec 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?