Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getmail: deprecate & fix install #113253

Closed
wants to merge 3 commits into from

Conversation

n-thumann
Copy link
Contributor

@n-thumann n-thumann commented Oct 16, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

According to https://pyropus.ca./software/getmail/documentation.html#python3 getmail only supports Python 2 and should therefore be deprecated. I installed it manually and can confirm that it doesn't run on Python 3.

Part of #86422 (but no longer needed since deprecation).
Not part of, but related to Python 2 deprecations in #93940.
Depends on Homebrew/brew#14004 to fix the downloading.

This Formula also requires brewed curl, because downloading it using a older version of curl fails:

➜  ~ /usr/bin/curl -V && /usr/bin/curl https://pyropus.ca/software/getmail/old-versions/getmail-5.15.tar.gz -L --max-redirs 25
curl 7.79.1 (x86_64-apple-darwin21.0) libcurl/7.79.1 (SecureTransport) LibreSSL/3.3.6 zlib/1.2.11 nghttp2/1.45.1
Release-Date: 2021-09-22
Protocols: dict file ftp ftps gopher gophers http https imap imaps ldap ldaps mqtt pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
Features: alt-svc AsynchDNS GSS-API HSTS HTTP2 HTTPS-proxy IPv6 Kerberos Largefile libz MultiSSL NTLM NTLM_WB SPNEGO SSL UnixSockets
curl: (47) Maximum (25) redirects followed

Brewed curl, however, can

➜  ~ curl -V && curl https://pyropus.ca/software/getmail/old-versions/getmail-5.15.tar.gz -L --max-redirs 25
curl 7.85.0 (x86_64-apple-darwin21.5.0) libcurl/7.85.0 (SecureTransport) OpenSSL/1.1.1q zlib/1.2.11 brotli/1.0.9 zstd/1.5.2 libidn2/2.3.3 libssh2/1.10.0 nghttp2/1.50.0 librtmp/2.3
Release-Date: 2022-08-31
Protocols: dict file ftp ftps gopher gophers http https imap imaps ldap ldaps mqtt pop3 pop3s rtmp rtsp scp sftp smb smbs smtp smtps telnet tftp
Features: alt-svc AsynchDNS brotli GSS-API HSTS HTTP2 HTTPS-proxy IDN IPv6 Kerberos Largefile libz MultiSSL NTLM NTLM_WB SPNEGO SSL threadsafe TLS-SRP UnixSockets zstd
Warning: Binary output can mess up your terminal. Use "--output -" to tell
Warning: curl to output it to your terminal anyway, or consider "--output
Warning: <FILE>" to save to a file.

@BrewTestBot BrewTestBot added formula deprecated Formula deprecated no Linux bottle Formula has no Linux bottle labels Oct 16, 2022
@n-thumann n-thumann changed the title getmail: deprecate getmail: deprecate & fix install Oct 16, 2022
@Bo98 Bo98 added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-bottles Merge without publishing bottles labels Oct 16, 2022
Bo98
Bo98 previously approved these changes Oct 16, 2022
Formula/getmail.rb Outdated Show resolved Hide resolved
Co-authored-by: Sean Molenaar <SMillerDev@users.noreply.github.com>
@BrewTestBot BrewTestBot added formula disabled Formula disabled and removed formula deprecated Formula deprecated labels Oct 17, 2022
@n-thumann
Copy link
Contributor Author

In case you're wondering: The CI fails, because Python 2 is obviously is required. When pointing /usr/bin/python to Python 2 locally brew test getmail works :)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Nov 8, 2022
@github-actions github-actions bot closed this Nov 15, 2022
@chenrui333 chenrui333 reopened this Jan 1, 2023
@chenrui333 chenrui333 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Jan 1, 2023
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Jan 1, 2023
@chenrui333
Copy link
Member

since we just disable the formula in here, maybe just a syntax build would be good enough?

@github-actions github-actions bot removed the stale No recent activity label Jan 1, 2023
@chenrui333 chenrui333 added the CI-requeued PR has been re-added to the queue label Jan 1, 2023
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Feb 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-requeued PR has been re-added to the queue CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula disabled Formula disabled hacktoberfest-accepted no Linux bottle Formula has no Linux bottle outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants