-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fanyi: fix test for Linux #113248
fanyi: fix test for Linux #113248
Conversation
This formula actually already has a Linux bottle, so the test succeeded on Linux in CI at some point. |
Hm, you're right! |
The test on Ubuntu still runs through (https://github.com/Homebrew/homebrew-core/actions/runs/3260182703/jobs/5353576582), even without |
If it fixes an issue locally, then I'm fine with merging this. |
346da98
to
1702283
Compare
Great! Reopened & remove test commit. |
Sounds like a regression |
🤖 A scheduled task has triggered a merge. |
If you don't mind, could you add |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?This PR fixes the test of
fanyi
for Linux.Part of #86422.
Fancy will pronunciate the word by default. On Linux however, this requires some additional text-to-speech libraries to be installed, hence the test fails. On macOS this works without any additional libraries.
I therefore disabled the acoustic pronunciation, because this isn't useful for testing anyways (and also fixed a typo). This can be also considered unwanted, because a test for this Formula shouldn't cause you Mac to play sounds.