Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql: drop GCC dependency #112220

Closed
wants to merge 2 commits into from
Closed

mysql: drop GCC dependency #112220

wants to merge 2 commits into from

Conversation

fxcoudert
Copy link
Member

Part of #110010

@fxcoudert fxcoudert added CI-linux-self-hosted Build on Linux self-hosted runner long build Set a long timeout for formula testing linux/drop-gcc-dependency labels Oct 3, 2022
@BrewTestBot BrewTestBot added the icu4c ICU use is a significant feature of the PR or issue label Oct 3, 2022
@fxcoudert fxcoudert mentioned this pull request Oct 3, 2022
Closed
@fxcoudert fxcoudert added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Oct 3, 2022
@cho-m cho-m removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Oct 3, 2022
@danielnachun
Copy link
Member

danielnachun commented Oct 3, 2022 •
edited
Loading

This probably doesn't need the self-hosted runner for dependent testing on Linux. That is only needed if the run takes more than 6 hours. This looks like it may need not even need a long build label.

@danielnachun danielnachun removed CI-linux-self-hosted Build on Linux self-hosted runner long build Set a long timeout for formula testing labels Oct 3, 2022
@danielnachun
Copy link
Member

It turns out mysql now needs to depend on libtirpc so I've added that.

@danielnachun danielnachun added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Oct 4, 2022
danielnachun
danielnachun approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@danielnachun danielnachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The qt-mysql failure is expected so this should be good to merge.

@BrewTestBot
Copy link
Member

:shipit: @danielnachun has triggered a merge.

@fxcoudert fxcoudert deleted the mysql branch October 4, 2022 07:21
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 11, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danielnachun danielnachun danielnachun approved these changes

Assignees
No one assigned
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. hacktoberfest-accepted icu4c ICU use is a significant feature of the PR or issue linux/drop-gcc-dependency outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fxcoudert @danielnachun @BrewTestBot @cho-m