Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netcdf 4.9.0, netcdf-cxx 4.3.1, netcdf-fortran 4.6.0 #112159

Closed
wants to merge 3 commits into from
Closed

netcdf 4.9.0, netcdf-cxx 4.3.1, netcdf-fortran 4.6.0 #112159

wants to merge 3 commits into from

Conversation

jonchang
Copy link
Contributor

@jonchang jonchang commented Oct 2, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Closes #106520.

Splits the netcdf formula into its C++ and Fortran versions. This ensures that livecheck will be able to detect updates, as otherwise they would have been hidden behind resource blocks. This also adds a test for the C++ version of the netcdf bindings. Finally, modernize and enable parallel building with the CMake --build method.

There will be audit failures (pre-existing from netcdf) for non-libraries installed to lib/.

@jonchang
Copy link
Contributor Author

jonchang commented Oct 2, 2022

I'll add the patch to formula-patches once I know it builds on CI

@jonchang jonchang added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Oct 2, 2022
@danielnachun
Copy link
Member

Linux test failures will be fixed by #111800. Not sure what's wrong with netcdf-cxx yet - maybe conflicting files?

jonchang and others added 3 commits October 2, 2022 15:59
Splits netcdf into netcdf-cxx and netcdf-fortran.

Co-Authored-By: owine <owine@users.noreply.github.com>
Split off from the main netcdf formula.
Split off from the main netcdf formula.
@jonchang
Copy link
Contributor Author

jonchang commented Oct 2, 2022

Yea it's a problem with the shims replacement. Not sure why the error wasn't showing up in logs.

@jonchang
Copy link
Contributor Author

jonchang commented Oct 3, 2022

Linux failures were caused by boost linkage (now fixed). New formula audit failures are known from netcdf. Going to merge this.

@BrewTestBot
Copy link
Member

:shipit: @jonchang has triggered a merge.

@jonchang jonchang mentioned this pull request Oct 3, 2022
@jonchang jonchang deleted the netcdf-split branch October 3, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants