Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra boost dependents #111800

Closed
wants to merge 98 commits into from
Closed

Extra boost dependents #111800

wants to merge 98 commits into from

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

I'm splitting these off from #109752 because there's no way we'll ever get a PR that rebuilds that many formulae merged.

@carlocab carlocab added CI-linux-self-hosted Build on Linux self-hosted runner long build Set a long timeout for formula testing labels Sep 27, 2022
@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Sep 27, 2022
@carlocab carlocab added CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Sep 27, 2022
@cho-m cho-m removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Sep 27, 2022
@carlocab carlocab mentioned this pull request Sep 28, 2022
6 tasks
@carlocab carlocab added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Oct 1, 2022
@carlocab carlocab added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. labels Oct 1, 2022
@BrewTestBot BrewTestBot removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 1, 2022
@carlocab carlocab added the no long build conflict Do not allow merging other pull requests when files conflict with this one label Oct 1, 2022
@danielnachun
Copy link
Member

danielnachun commented Oct 2, 2022

We should fix the Linux failures in follow up PRs. Here is a list:

@carlocab carlocab removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Oct 2, 2022
cho-m
cho-m previously approved these changes Oct 2, 2022
@carlocab
Copy link
Member Author

carlocab commented Oct 2, 2022

We should drop the failed Linux builds before merging. Someone needs to do brew pr-pull and push the bottle commits here. I can do this later when I get off mobile.

@danielnachun
Copy link
Member

We should drop the failed Linux builds before merging. Someone needs to do brew pr-pull and push the bottle commits here. I can do this later when I get off mobile.

I'm not entirely sure how this works. Does this mean we drop the revision bumps for the failed builds without rerunning CI again? Or do we need another CI run?

@danielnachun
Copy link
Member

I have no idea what is wrong with fuego but it seems unrelated to migration, so I think we should drop the Linux bottle until we know why the test is failing. The other build failures will all be fixed by various PRs.

@carlocab
Copy link
Member Author

carlocab commented Oct 2, 2022

Downloading the bottles. May take a bit.

@carlocab
Copy link
Member Author

carlocab commented Oct 2, 2022

I'm not entirely sure how this works. Does this mean we drop the revision bumps for the failed builds without rerunning CI again? Or do we need another CI run?

We can drop them without running CI again. Doing that now.

@carlocab carlocab added do not merge CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. and removed CI-linux-self-hosted Build on Linux self-hosted runner long build Set a long timeout for formula testing CI-skip-dependents Pass --skip-dependents to brew test-bot. labels Oct 2, 2022
@carlocab
Copy link
Member Author

carlocab commented Oct 2, 2022

Bottles are still uploading, but will merge this when they're ready.

@carlocab carlocab requested a review from cho-m October 2, 2022 23:00
@carlocab carlocab added automerge-skip `brew pr-automerge` will skip this pull request CI-no-bottles Merge without publishing bottles labels Oct 2, 2022
@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@carlocab carlocab deleted the boost-part2 branch October 2, 2022 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. no long build conflict Do not allow merging other pull requests when files conflict with this one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants