Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyside 6.3.0 #103665

Closed
wants to merge 1 commit into from
Closed

pyside 6.3.0 #103665

wants to merge 1 commit into from

Conversation

danielnachun
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added no Linux bottle Formula has no Linux bottle python Python use is a significant feature of the PR or issue labels Jun 15, 2022
@danielnachun
Copy link
Member Author

I've refactored this to use CMake for the build process as we already do for pyside@2. This is a much better system for package managers to use and lets us get rid of a lot of cruft. The fix I had to add for building on macOS needs to be upstreamed assuming this passes CI.

@danielnachun
Copy link
Member Author

The metaobjectdump.py and project.py files are not shebang scripts as I originally thought but must be invoked using python3. I agree with the audit that these don't belong in bin. What's the best place to move these to? I was thinking share, but I'm not sure what we've done in previous formulae with Python scripts like this.

@danielnachun danielnachun force-pushed the pyside branch 3 times, most recently from bb01b35 to 2984692 Compare June 15, 2022 22:48
@danielnachun
Copy link
Member Author

I got this to build by moving the Python scripts to pkgshare. Any thoughts on whether this acceptable? I have everything ready to upstream to Qt Gerrit for the macOS fix to the CMake build, but I want to make sure we're okay with the changes I've made before submitting it.

@SMillerDev
Copy link
Member

Yeah, sounds good

@danielnachun
Copy link
Member Author

I submitted the macOS fix to the PySide Gerrit and linked it in a comment so we can merge this once the CI run is done.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@danielnachun danielnachun deleted the pyside branch June 16, 2022 23:01
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 17, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no Linux bottle Formula has no Linux bottle outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants